Apache OpenOffice (AOO) Bugzilla – Issue 64798
patch to enable using neon 0.26 api for webdav
Last modified: 2006-07-27 16:30:52 UTC
This patch fixes compile errors with system neon 0.26.0.
Created attachment 36066 [details] system neon 0.26.0
Created attachment 36078 [details] version 2
Reassign to webdav owner.
KSO->ABI: The patch looks good to me. We should integrate it asap.
accepted
geki->abi: Any chance you could add it to a CWS? :)
abi: any status on this? In case you don't have a cws opwen for that currently I can add it to configure18
.
fixed in cws configure18
Ause: please analyse, if you need some changes to your environment - like NEON_VERSION variable or so.
@pavel: thanks for the hint. introduced NEON_VERSION to SO environment to avoid breakage here: ucb/source/ucp/webdav/NeonSession.hxx:52:18: operator '>=' has no left operand
kso->geki: IMO, neon's config.h already defines version information: /* Define to be the neon version string */ #define NEON_VERSION "0.24.7" /* Define to be major number of neon version */ #define NEON_VERSION_MAJOR (0) /* Define to be minor number of neon version */ #define NEON_VERSION_MINOR (24) Thus, if you need neon version only in cxx/hxx (seems to be the case for now), there is no need to introduce NEON_VERSION at all. This would simplify your patch alot.
There is no config.h with Gentoos neon version. There is also no NEON_VERSION define in any of the neon header files.
kso->geki: neon's config.h gets created by neon's configure script. neon sources do not even compile without this header file. Thus, you need to run configure once, for instance in order to create config.h before you can build neon.
kso: of course there is none. config.h is *NOT* a public header and therefore not installed in packages. the public neon headers do *NOT* contain version macros... And it is bad to install config.h to use that. So using config.h might help for you, using internal neon, but not for syste-neon.
kso->rene,geki: You're right. My fault. config.h is a private header. I overlooked this in the first place.
seen in m179. closing.