Issue 64798 - patch to enable using neon 0.26 api for webdav
Summary: patch to enable using neon 0.26 api for webdav
Status: CLOSED FIXED
Alias: None
Product: ucb
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.4
Assignee: rene
QA Contact: issues@ucb
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-26 17:48 UTC by geki
Modified: 2006-07-27 16:30 UTC (History)
5 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
system neon 0.26.0 (3.84 KB, patch)
2006-04-26 17:49 UTC, geki
no flags Details | Diff
version 2 (10.47 KB, patch)
2006-04-26 22:54 UTC, geki
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description geki 2006-04-26 17:48:21 UTC
This patch fixes compile errors with system neon 0.26.0.
Comment 1 geki 2006-04-26 17:49:08 UTC
Created attachment 36066 [details]
system neon 0.26.0
Comment 2 geki 2006-04-26 22:54:59 UTC
Created attachment 36078 [details]
version 2
Comment 3 geki 2006-04-27 10:49:53 UTC
Reassign to webdav owner.
Comment 4 kai.sommerfeld 2006-05-02 16:25:53 UTC
KSO->ABI: The patch looks good to me. We should integrate it asap.
Comment 5 andreas.bille 2006-05-22 09:26:16 UTC
accepted
Comment 6 geki 2006-06-14 10:21:18 UTC
geki->abi: Any chance you could add it to a CWS? :)
Comment 7 rene 2006-07-11 13:29:07 UTC
abi: any status on this? In case you don't have a cws opwen for that currently 
I can add it to configure18
Comment 8 rene 2006-07-13 16:17:11 UTC
.
Comment 9 rene 2006-07-13 16:18:32 UTC
fixed in cws configure18
Comment 10 pavel 2006-07-17 19:09:11 UTC
Ause: please analyse, if you need some changes to your environment - like
NEON_VERSION variable or so.
Comment 11 hjs 2006-07-18 13:16:25 UTC
@pavel: thanks for the hint. introduced NEON_VERSION to SO environment to avoid
breakage here:
ucb/source/ucp/webdav/NeonSession.hxx:52:18: operator '>=' has no left operand
Comment 12 kai.sommerfeld 2006-07-19 08:24:02 UTC
kso->geki: IMO, neon's config.h already defines version information:

/* Define to be the neon version string */
#define NEON_VERSION "0.24.7"

/* Define to be major number of neon version */
#define NEON_VERSION_MAJOR (0)

/* Define to be minor number of neon version */
#define NEON_VERSION_MINOR (24)

Thus, if you need neon version only in cxx/hxx (seems to be the case for now),
there is no need to introduce NEON_VERSION at all. This would simplify your
patch alot.
Comment 13 geki 2006-07-19 15:10:10 UTC
There is no config.h with Gentoos neon version. There is also no NEON_VERSION
define in any of the neon header files.
Comment 14 kai.sommerfeld 2006-07-19 15:39:53 UTC
kso->geki: neon's config.h gets created by neon's configure script. neon sources
do not even compile without this header file. Thus, you need to run configure
once, for instance in order to create config.h before you can build neon.
Comment 15 rene 2006-07-19 21:12:26 UTC
kso: of course there is none. config.h is *NOT* a public header and therefore not
installed in packages. the public neon headers do *NOT* contain version macros...
And it is bad to install config.h to use that.

So using config.h might help for you, using internal neon, but not for syste-neon.
Comment 16 kai.sommerfeld 2006-07-20 07:56:02 UTC
kso->rene,geki: You're right. My fault. config.h is a private header. I
overlooked this in the first place.
Comment 17 geki 2006-07-27 16:30:52 UTC
seen in m179. closing.