Issue 64800 - FolderPicker cannot open with display of a given folder
Summary: FolderPicker cannot open with display of a given folder
Status: CLOSED FIXED
Alias: None
Product: App Dev
Classification: Unclassified
Component: api (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All Windows XP
: P3 Trivial
Target Milestone: ---
Assignee: thorsten.martens
QA Contact: issues@api
URL:
Keywords:
: 67643 80972 97062 (view as issue list)
Depends on:
Blocks:
 
Reported: 2006-04-26 19:19 UTC by bmarcelly
Modified: 2017-05-20 09:32 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Basic macro calling FolderPicker (8.48 KB, application/vnd.sun.xml.writer)
2006-04-26 19:20 UTC, bmarcelly
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description bmarcelly 2006-04-26 19:19:16 UTC
Tested on Windows XP SP2, OpenOffice Options : "Use OpenOffice.org dialogs" NOT 
checked.

In the XFolderPicker interface, method setDisplayDirectory sets the root directory that 
the FolderPicker should display.
This was the case with 1.1.x (currently tested with 1.1.4)
This is not the case with 2.0.x (currently tested with 2.0.2)

Next attachment contains a macro to show this.
Comment 1 bmarcelly 2006-04-26 19:20:18 UTC
Created attachment 36072 [details]
Basic macro calling FolderPicker
Comment 2 stephan.wunderlich 2006-04-27 09:03:51 UTC
sw->tra: this used to be your area methinks
Comment 3 Martin Hollmichel 2006-08-07 09:56:03 UTC
reassign 
Comment 4 hennes.rohling 2007-02-05 13:44:26 UTC
.
Comment 5 hennes.rohling 2007-02-05 13:46:40 UTC
*** Issue 67643 has been marked as a duplicate of this issue. ***
Comment 6 hennes.rohling 2007-02-12 11:57:18 UTC
.
Comment 7 hennes.rohling 2007-08-02 14:16:52 UTC
Adjusted target to CWS.
Comment 8 cno 2007-08-02 18:39:35 UTC
Issue #79211 is in the same area.
Maybe, maybe, it has some relationship with this one?
Comment 9 cno 2007-08-23 19:11:21 UTC
*** Issue 80972 has been marked as a duplicate of this issue. ***
Comment 10 kai.sommerfeld 2007-12-12 09:26:27 UTC
.
Comment 11 kai.sommerfeld 2008-01-14 11:21:17 UTC
No time left to fix this for 2.4.
Comment 12 hennes.rohling 2008-05-30 11:27:18 UTC
Retargeted.
Comment 13 villeroy 2008-06-04 19:06:20 UTC
Works for me with system paths rather than URLs.
OOo 2.4 (Sun), Linux.
Comment 14 Mathias_Bauer 2009-06-10 13:14:11 UTC
Here's a patch stolen from issue 97062:

Index: MtaFop.cxx
===================================================================
--- MtaFop.cxx	(revision 263749)
+++ MtaFop.cxx	(working copy)
@@ -470,12 +470,6 @@
 			    NULL );
 	    }
 	}
-	
-	if (pIMalloc.is())
-		pIMalloc->Free(lpItemIdList);
-
-	lpItemIdList = NULL;
-	
 	return lpItemIdList;
 }
 
Comment 15 Mathias_Bauer 2009-06-10 13:14:32 UTC
*** Issue 97062 has been marked as a duplicate of this issue. ***
Comment 16 Mathias_Bauer 2009-06-24 09:24:19 UTC
Carsten, can you please consider this patch as part of your file picker rework
on Windows?
Comment 17 carsten.driesner 2009-06-24 09:45:34 UTC
cd: Accepted.
Comment 18 carsten.driesner 2009-07-01 13:31:08 UTC
@bmarcelly: Thanks for your patch I used it as base for my own changes.
According to the documentation IShellFolder::ParseDisplayName  PIDLIST_RELATIVE
*ppidl, only as a out parameter. Therefore allocating memory before calling
ParseDisplayName makes no sense and creates a memory leak. The original code
looks very strange and is definitely wrong.

cd: Fixed.
Comment 19 carsten.driesner 2009-07-10 15:08:28 UTC
cd->tm: Please verify.
Comment 20 thorsten.martens 2009-07-21 09:03:50 UTC
Checked and verified in cws filepicker01 -> OK !