Issue 64889 - [PATCH] Increase MAXLINELENGTH on Win32
Summary: [PATCH] Increase MAXLINELENGTH on Win32
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-28 13:56 UTC by shay
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch referred to above. (1.69 KB, patch)
2006-04-28 13:57 UTC, shay 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description shay 2006-04-28 13:56:32 UTC 
Hi Volker,

I've just had a bug report from a perl user complaining that he can't build a
certain perl module using my build of OpenOffice dmake:

http://rt.cpan.org/Public/Bug/Display.html?id=18967

The solution for me is simple: I will increase the default MAXLINELENGTH from
8190 to 32766, exactly as per issue 47137:

http://www.openoffice.org/issues/show_bug.cgi?id=47137

A patch to do this follows.

My question to you is: Do you want to apply this patch to the OpenOffice
sources?  If not then I'll just patch my version and release a new build with an
updated "diff" file showing the changes I have made.

I would prefer to have the changes made in the OpenOffice sources so that I
don't have to keep applying the patch every time I take the latest sources for
making new builds in the future.

Btw, where are the "latest" sources now?  I just checked out
cws_src680_dmake43p01 as I have done before, but I see from
http://tools.openoffice.org/dmake/ that 4.4 has now been released.  Is there a
new version working towards 4.5 yet?

Cheers,
- Steve
Comment 1 shay 2006-04-28 13:57:34 UTC 
Created attachment 36137 [details]
Patch referred to above.
Comment 2 quetschke 2006-04-28 15:21:23 UTC 
Hi Steve,

I have nothing against increasing MAXLINELENGTH in the various ruletab.c files,
but there is an easier way, we could just add

MAXLINELENGTH	= 65530

to dmake/startup/startup.mk. But it makes sense to increase the hardcoded limit.

The new development version will be in cws_src680_dmake45 but I have not committed
anything yet.
Comment 3 shay 2006-04-28 15:28:10 UTC 
I told the person who reported the bug about just editing startup.mk as a quick
fix for him already, but I think changing the hard-coded default is better
because that value is displayed by the "dmake -V" output.

So I'll look out for it being applied to cws_src680_dmake45 sometime, then.

Thanks.
Comment 4 quetschke 2006-06-15 03:45:27 UTC 
Committed to dmake45.

Reassigning for verification.

@ause: This change is "risk free" for OOo as we have
MAXLINELENGTH	= 65530
in the startup.mk.
Comment 5 quetschke 2006-06-15 03:45:51 UTC 
@ause: Please verify.
Comment 6 shay 2006-06-19 12:23:59 UTC 
Tested, and I confirm that my problem is resolved by this change.
Comment 7 hjs 2006-06-26 15:32:31 UTC 
.
Comment 8 hjs 2006-07-07 15:23:47 UTC 
.