Issue 65281 - dmake crashes on numeric comparison with empty macro
Summary: dmake crashes on numeric comparison with empty macro
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-11 04:12 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (3.88 KB, patch)
2006-05-11 04:28 UTC, quetschke 		no flags Details | Diff
Patch for dmake (2.39 KB, patch)
2006-06-16 19:28 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-05-11 04:12:31 UTC 
See issue 65182 for details, dmake crashes on something like this:

MYVAR=

.IF $(MYVAR) >= "122"
...
Comment 1 quetschke 2006-05-11 04:28:41 UTC 
Created attachment 36390 [details]
Patch for dmake
Comment 2 quetschke 2006-05-11 04:41:53 UTC 
Committed to CWS dmake45.

Reassigning for verification.
Comment 3 quetschke 2006-05-11 04:42:33 UTC 
@ause: Please verify.
Comment 4 quetschke 2006-06-15 18:08:47 UTC 
Reopen, it seems the fix breaks this makefile:

-- xxx.mk (native W32 example) --
# dmake.exe -rf xxx.mk

.IMPORT .IGNORE : COMSPEC

all :
.IF $(XXXXX) == $(NULL)
	@echo "This is true"
.ELSE
	@echo "This is not true"
.END
-- xxx.mk --

Puting " around the macros fixes this.

This construct is used in dmakes (not used by OOo) startup macros
to set SHELL. This bug breaks everything that uses dmake.

Steve, thanks for testing! I'll fix this asap.
Comment 5 quetschke 2006-06-16 19:28:00 UTC 
Created attachment 37204 [details]
Patch for dmake
Comment 6 quetschke 2006-06-16 19:47:42 UTC 
Committed and added testcase.

@ause: Please verify.
Comment 7 shay 2006-06-19 12:25:41 UTC 
Re-tested the makefile(s) that I had found were broken by SHELL not getting set,
and I confirm that they are now working OK again.
Comment 8 hjs 2006-06-26 17:57:24 UTC 
looks good
Comment 9 hjs 2006-07-07 15:36:06 UTC 
.