Issue 65360 - dmake silently skips .<suffix> targets when prerequisits are given
Summary: dmake silently skips .<suffix> targets when prerequisits are given
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-14 17:31 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (1.66 KB, patch)
2006-05-14 17:55 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-05-14 17:31:45 UTC 
Before issue 65122 changed this hunk:

@@ -849,18 +872,23 @@
 	    prereq = _build_graph(op,tg1,prereq);
       }
       else if( !(tg1->ce_flag & F_SPECIAL) && 
-		(prereq == NIL(CELL)) &&
 		(p = _is_magic( tg1->CE_NAME )) != NIL(char))
          _do_magic( op, p, tg1, prereq, attr, set_dir );

meta .<suffix> targets were just silently ignored despite the illegal syntax.

As issue 65333 shows that bug was actually relied on by the OOo build.
Comment 1 quetschke 2006-05-14 17:55:00 UTC 
Created attachment 36453 [details]
Patch for dmake
Comment 2 quetschke 2006-05-14 17:58:46 UTC 
Committed to CWS dmake45.
Comment 3 quetschke 2006-06-04 02:19:21 UTC 
We now issue a warning like:

Warning: -- Ignoring AUGMAKE meta-target [.nada] because prerequisites are present.

Added a testcase for this. Reassigning for verification.
Comment 4 quetschke 2006-06-04 02:20:09 UTC 
@ause: Please verify.
Comment 5 hjs 2006-06-27 10:12:34 UTC 
seen warning in the expected case
Comment 6 hjs 2006-07-07 15:38:46 UTC 
.
Comment 7 hjs 2006-07-07 15:39:09 UTC 
.