Apache OpenOffice (AOO) Bugzilla – Issue 65979
[PATCH] system db check cleanup
Last modified: 2009-07-20 15:21:39 UTC
Summary says it. Patch is on URL. The row of db versions to test may need to be resorted. Any other tweaks?
With that patch system portaudio check fails. For this to fix you need: http://go-oo.org/patches/src680/system-portaudio-use-lpthread.diff
huh? OOo's code is still written for db4.1/4.2. Checking for 4.3 and 4.4 is broken becaus ethat will *not* work. Yes, I know ooo-build has patches for this, but the OOo tree has not (and getting it upstream will be hard since Java has no preprocessor...)
IMHO, the -lpthread patch also is wrong. fix your portaudio to build with -lpthread...
the -lpthread patch IMHO/IIRC also is wrong. fix your portaudio to build with -lpthread...
So I drop the checks for 4.3 and 4.4 versions before I attach a patch to this issue. But is this change ok in general? Or is anything else not ok?
Created attachment 36852 [details] system db check
reassign for review.
any news here to get this into a cws, or not, or what? :)
geki: yes, this patch is imho not OK still: a) db 4.2 and 4.3 still work. That your portaudio is broken doesn't affect this. fix your portaudio. b) the db C++ stuff isn't used, no need for checking for it c) the whole dbX, db-X.Y is distri-specific stuff.. (especially in the includes case..) I'll now commit a patch to configure21 allowing also db4.3, db4.4 and db4.5 as that apparently works and to remove the db.jar check as that now is unneeded with the native helplinker in m215.
committed to cws configure21 as written in prevoius comment,
to a) Thats just unrelated. no need to comment. ;) I just inlined a link in case someone else gets that error. to b) That was there so I changed it as well. I just do not delete something. Someone else has to decide that, not me. ;) to c) I hope it just configures now with your changes. It is annoying that each distribution has different naming and versioning of libraries. ;) ...bla.
for c): no, it's a problem of db upstream which causes the distros to reinvent stuff to make them parallel installable...
for c): no, it's a problem of db upstream which causes the distros to reinvent stuff to make them parallel installable... (which imho is not needed in any case anyway, just make the -dev stuff conflict..)
.
Verified in configure21.
This issue is closed automatically and wasn't rechecked in a current version of OOo. The fixed issue should be integrated in OOo since more than half a year. If you think this issue isn't fixed in a current version (OOo 3.1), please reopen it and change the field 'Target Milestone' accordingly. If you want to download a current version of OOo => http://download.openoffice.org/index.html If you want to know more about the handling of fixed/verified issues => http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues