Issue 66083 - Error out on AUGMAKE meta and normal targets in the same definition
Summary: Error out on AUGMAKE meta and normal targets in the same definition
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-04 03:14 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (2.32 KB, patch)
2006-06-13 06:25 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-06-04 03:14:24 UTC 
The following testcase works, but should at least issue a warning as
.<suffix> targets are meta targets with a "different" prerequisite
definition. For example:

-- test.mk --
SHELL*:=/bin/sh 
SHELLFLAGS*:=-ce

.NIX aaa : ; +echo "Normal and meta target together"

something.NIX :
	+echo "A target."
-- test.mk --

$ dmake/dmake.exe -rf test.mk something
echo "A target."
A target.
echo "Normal and meta target together"
Normal and meta target together
Comment 1 quetschke 2006-06-13 06:25:25 UTC 
Created attachment 37101 [details]
Patch for dmake
Comment 2 quetschke 2006-06-13 16:08:08 UTC 
IMHO mixing AUGMAKE meta and normal targets warrants an error and not a warning
as prerequisites are treated differently. Committed previous patch and a testcase.

Reassigning for verification.
Comment 3 quetschke 2006-06-13 16:08:39 UTC 
@ause: Please verify.
Comment 4 hjs 2006-06-27 10:42:04 UTC 
errors out as expected
Comment 5 hjs 2006-07-07 15:39:41 UTC 
.