Issue 66425 - Text crossed out with / or X is not crossed out in running presentation.
Summary: Text crossed out with / or X is not crossed out in running presentation.
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: viewing (show other issues)
Version: 680m162
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: christian.guenther
QA Contact: issues@graphics
URL:
Keywords:
: 55708 72486 (view as issue list)
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2006-06-14 13:15 UTC by christian.guenther
Modified: 2008-07-01 17:05 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
the patch of i66425 (4.17 KB, text/plain)
2007-10-24 08:59 UTC, liujl 		no flags Details
the patch of i66425 (4.40 KB, text/plain)
2007-11-12 02:37 UTC, liujl 		no flags Details
I have revised the imprenderer.cxx and deleted the change of textaction.cxx (3.72 KB, text/plain)
2007-11-13 02:52 UTC, liujl 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description christian.guenther 2006-06-14 13:15:07 UTC 
- start an Impress
- write some text (it doesn't matter if textbox or outline text object)
- assign the attribute strikethrough to the text and choose / or X to strikethrough
- start the presentation
- the text is not crossed out in the  running presentation
Comment 1 thb 2006-06-27 17:40:03 UTC 
@hdu: seems to be missing from your vcl emulation in implrenderer.cxx - care to
take a look?
Comment 2 christian.guenther 2007-01-04 09:47:18 UTC 
*** Issue 72486 has been marked as a duplicate of this issue. ***
Comment 3 liujl 2007-10-24 08:59:31 UTC 
Created attachment 49108 [details]
the patch of i66425
Comment 4 hdu@apache.org 2007-10-24 09:49:02 UTC 
Thanks for the patch!

Importing VCL-internal functionality like OutputDevice::ImplLayout() in the canvas module is not a good 
idea though, especially when it is only used to measure text. Better call OutputDevice::GetTextWidth() or 
GetTextArray() and get rid of including the newly included header file.

Here is another point that may be interesting in this context. Since there usually is a slight mismatch 
between the width of the original text and the strikeout text maybe we should consider to either justify 
the strikeout text to match the original text or position it in the middle. On the other hand the way it is 
implemented now works like a typewriter would cross out text, so maybe this is good enough.
Comment 5 Martin Hollmichel 2007-11-09 17:18:16 UTC 
set target from 2.x to 3.x according to
http://wiki.services.openoffice.org/wiki/Target_3x
Comment 6 liujl 2007-11-12 02:37:09 UTC 
Created attachment 49586 [details]
the patch of i66425
Comment 7 hdu@apache.org 2007-11-12 09:00:47 UTC 
@liujianli: that is much better, thank you!

@thb: do you happen to have a canvas CWS where this patch could be applied
Comment 8 liujl 2007-11-13 02:52:43 UTC 
Created attachment 49605 [details]
I have revised the imprenderer.cxx and deleted the change of textaction.cxx
Comment 9 thb 2007-11-13 11:20:51 UTC 
Fix looks excellent, big thanks!
Comment 10 clippka 2008-04-15 14:21:15 UTC 
thorsten, what is the status of this issue. Can I just take the patch and apply it?
Comment 11 thb 2008-04-15 16:06:26 UTC 
I have to apologize - this one slipped by me. Fix taken as-is, and committed to
CWS canvas05. Thx for the good work again, liujl!
Comment 12 thb 2008-04-15 16:07:15 UTC 
Adapting target milestone.
Comment 13 liujianli 2008-04-16 02:19:59 UTC 
Should be thanks for Herbert,he give me a lot of help.
Comment 14 thb 2008-06-02 22:08:42 UTC 
Fixed in CWS canvas05, please verify
Comment 15 christian.guenther 2008-06-19 17:55:36 UTC 
CGU: Verified in cws canvas05
Comment 16 thb 2008-06-27 14:33:40 UTC 
*** Issue 55708 has been marked as a duplicate of this issue. ***
Comment 17 christian.guenther 2008-07-01 17:05:03 UTC 
CGU: integrated in dev300m22