Issue 6658 - Enable Thai 8 bits data exchange.
Summary: Enable Thai 8 bits data exchange.
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: nospam4obr
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks: 6659
  Show dependency tree
 
Reported: 2002-07-31 08:11 UTC by samphan
Modified: 2006-08-02 02:37 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description samphan 2002-07-31 08:11:36 UTC
Add the missing tis-620/iso-8859-11/windows-874 (Thai 8 bits encodings) entries
to various tables.
These are needed, for example, to be able to cut/paste/open/save single byte
text to/from other applications.
'tis-620' is the standard and original encoding for Thai, registered as a MIME
charset. 'windows-874' and 'iso-8859-11' can be thought of as aliases.
'windows-874' is needed for the internet data to/from Windows.
'iso-8859-11' is needed for the internet and the new Thai X locale.

**** file -- table/function
sal/osl/unx/nlsupport.c -- locale_extension_list, iso_language_list
sal/textenc/tencinfo.c -- UnixCharsetISOTab, MimeCharsetTab
tools/source/inet/inetmime.cxx -- getCharsetName, getCharsetEncoding


****
diff -urdP -X srcdiff.txt ../oo_1.0_src.orig/sal/osl/unx/nlsupport.c
sal/osl/unx/nlsupport.c
--- ../oo_1.0_src.orig/sal/osl/unx/nlsupport.c	Thu Apr 11 00:03:41 2002
+++ sal/osl/unx/nlsupport.c	Wed Jul 31 11:00:56 2002
@@ -672,6 +672,7 @@
     { "euc",          RTL_TEXTENCODING_EUC_JP      },
     { "iso8859-1",    RTL_TEXTENCODING_ISO_8859_1  },
     { "iso8859-10",   RTL_TEXTENCODING_ISO_8859_10 }, 
+    { "iso8859-11",   RTL_TEXTENCODING_MS_874      },
     { "iso8859-13",   RTL_TEXTENCODING_ISO_8859_13 }, 
     { "iso8859-14",   RTL_TEXTENCODING_ISO_8859_14 },
     { "iso8859-15",   RTL_TEXTENCODING_ISO_8859_15 },
@@ -688,6 +689,7 @@
 #if (0)
     { "sun_eu_greek", RTL_TEXTENCODING_DONTKNOW    },
 #endif
+    { "tis-620",      RTL_TEXTENCODING_MS_874      },
     { "utf-16",       RTL_TEXTENCODING_UNICODE     },
     { "utf-7",        RTL_TEXTENCODING_UTF7        },
     { "utf-8",        RTL_TEXTENCODING_UTF8        }
@@ -743,7 +745,7 @@
     { "sv",  RTL_TEXTENCODING_ISO_8859_1 }, 
     { "sw",  RTL_TEXTENCODING_ISO_8859_1 }, 
     { "ta",  RTL_TEXTENCODING_DONTKNOW }, 
-    { "th",  RTL_TEXTENCODING_DONTKNOW }, 
+    { "th",  RTL_TEXTENCODING_MS_874 }, 
     { "tr",  RTL_TEXTENCODING_ISO_8859_9 }, 
     { "tt",  RTL_TEXTENCODING_ISO_8859_5 }, 
     { "uk",  RTL_TEXTENCODING_ISO_8859_5 }, 
diff -urdP -X srcdiff.txt ../oo_1.0_src.orig/sal/textenc/tencinfo.c
sal/textenc/tencinfo.c
--- ../oo_1.0_src.orig/sal/textenc/tencinfo.c	Thu Feb 14 19:07:41 2002
+++ sal/textenc/tencinfo.c	Sun Jul 28 20:56:53 2002
@@ -464,6 +464,7 @@
         { "7", RTL_TEXTENCODING_ISO_8859_7 },
         { "8", RTL_TEXTENCODING_ISO_8859_8 },
         { "9", RTL_TEXTENCODING_ISO_8859_9 },
+
{ "11", RTL_TEXTENCODING_MS_874 },
         { NULL, RTL_TEXTENCODING_DONTKNOW }
     };
 
@@ -756,6 +757,7 @@
         { "iso885914", RTL_TEXTENCODING_ISO_8859_14 },
         { "iso885913", RTL_TEXTENCODING_ISO_8859_13 },
         { "iso885910", RTL_TEXTENCODING_ISO_8859_10 },
+
{ "iso885911", RTL_TEXTENCODING_MS_874 },
         { "iso88591", RTL_TEXTENCODING_ISO_8859_1 },
         { "iso88592", RTL_TEXTENCODING_ISO_8859_2 },
         { "iso88593", RTL_TEXTENCODING_ISO_8859_3 },
@@ -912,6 +914,8 @@
         { "gb18030", RTL_TEXTENCODING_GB_18030 },
             /* This is no actual MIME character set name, it's only a guess */
         { "big5hkscs", RTL_TEXTENCODING_BIG5_HKSCS },
+
{ "windows874", RTL_TEXTENCODING_MS_874 },
+
{ "tis620", RTL_TEXTENCODING_MS_874 },
         { NULL, RTL_TEXTENCODING_DONTKNOW }
     };
 
diff -urdP -X srcdiff.txt ../oo_1.0_src.orig/tools/source/inet/inetmime.cxx
tools/source/inet/inetmime.cxx
--- ../oo_1.0_src.orig/tools/source/inet/inetmime.cxx	Sat Oct 13 00:06:45 2001
+++ tools/source/inet/inetmime.cxx	Wed Jul 31 11:36:10 2002
@@ -1585,7 +1585,7 @@
 
			"IBM864", // RTL_TEXTENCODING_IBM_864
 
			"IBM866", // RTL_TEXTENCODING_IBM_866
 
			"IBM869", // RTL_TEXTENCODING_IBM_869
-
			0, // RTL_TEXTENCODING_MS_874
+
			"tis-620", // RTL_TEXTENCODING_MS_874
 
			"windows-1250", // RTL_TEXTENCODING_MS_1250
 
			"windows-1251", // RTL_TEXTENCODING_MS_1251
 
			"windows-1253", // RTL_TEXTENCODING_MS_1253
@@ -1841,6 +1841,7 @@
 
	{ "ISO-10646-UCS-4", RTL_TEXTENCODING_UCS4 },
 
	{ "CSUCS4", RTL_TEXTENCODING_UCS4 },
 
	{ "ISO-10646-UCS-2", RTL_TEXTENCODING_UCS2 },
+
	{ "TIS-620", RTL_TEXTENCODING_MS_874 }, // MIBenum: 2259
 
	{ "CSUNICODE", RTL_TEXTENCODING_UCS2 } };
 
 //============================================================================
Comment 1 nospam4obr 2002-08-01 06:16:42 UTC
I was told in i6659 that explicit support for TIS-620 has already been
added to 643 and head, so I wonder if these changes can be back-ported
to OOO_STABLE_1.
Comment 2 ooo 2002-08-04 15:57:08 UTC
Furthermore, as TIS-620/iso5889-11 and MS-874 are not equal
encondings, this patch is wrong.

And please attach diffs/patches as a file to the issue instead of
pasting them into the comment field which breaks the diffs by
reformatting them and changing whitespace and whatever.
Comment 3 samphan 2002-08-04 18:29:05 UTC
Sorry about pasting the patches :-(. I'm very new to IssueZilla and
didn't see the 'Create a new attchment' links before.

So, this is it for these patches. They're just simple hacks to support
Thai in OOo which we're using in our Thai version of OOo 1.0.1
(OfficeTLE). I understand that ignoring the differences between
TIS-620 and Windows-874 may pose some problems in the future such as
sending the wrong character to the internet.

Regarding TIS-620 vs Windows-874, please continue the discussion in
i6659. Thanks.
Comment 4 michael.bemmer 2003-03-12 14:08:07 UTC
As mentioned on the qa dev list on March 5th I will close all resolved
<wontfix/duplicate/worksforme/invalid> issues. Please see this posting for
details. First step in IssueZilla is unfortunately to set them to verified.
Comment 5 michael.bemmer 2003-03-12 14:32:32 UTC
As mentioned on the qa dev list on March 5th I will close all resolved
<wontfix/duplicate/worksforme/invalid> issues. Please see this posting for details. 
Comment 6 si6362 2006-08-02 02:37:04 UTC
--------------------------------------------------------------------------------

Add the missing tis-620/iso-8859-11/windows-874 (Thai 8 bits encodings) entries
to various tables.
These are needed, for example, to be able to cut/paste/open/save single byte
text to/from other applications.
'tis-620' is the standard and original encoding for Thai, registered as a MIME
charset. 'windows-874' and 'iso-8859-11' can be thought of as aliases.
'windows-874' is needed for the internet data to/from Windows.
'iso-8859-11' is needed for the internet and the new Thai X locale.

**** file -- table/function
sal/osl/unx/nlsupport.c -- locale_extension_list, iso_language_list
sal/textenc/tencinfo.c -- UnixCharsetISOTab, MimeCharsetTab
tools/source/inet/inetmime.cxx -- getCharsetName, getCharsetEncoding


****
diff -urdP -X srcdiff.txt ../oo_1.0_src.orig/sal/osl/unx/nlsupport.c
sal/osl/unx/nlsupport.c
--- ../oo_1.0_src.orig/sal/osl/unx/nlsupport.c	Thu Apr 11 00:03:41 2002
+++ sal/osl/unx/nlsupport.c	Wed Jul 31 11:00:56 2002
@@ -672,6 +672,7 @@
     { "euc",          RTL_TEXTENCODING_EUC_JP      },
     { "iso8859-1",    RTL_TEXTENCODING_ISO_8859_1  },
     { "iso8859-10",   RTL_TEXTENCODING_ISO_8859_10 }, 
+    { "iso8859-11",   RTL_TEXTENCODING_MS_874      },
     { "iso8859-13",   RTL_TEXTENCODING_ISO_8859_13 }, 
     { "iso8859-14",   RTL_TEXTENCODING_ISO_8859_14 },
     { "iso8859-15",   RTL_TEXTENCODING_ISO_8859_15 },
@@ -688,6 +689,7 @@
 #if (0)
     { "sun_eu_greek", RTL_TEXTENCODING_DONTKNOW    },
 #endif
+    { "tis-620",      RTL_TEXTENCODING_MS_874      },
     { "utf-16",       RTL_TEXTENCODING_UNICODE     },
     { "utf-7",        RTL_TEXTENCODING_UTF7        },
     { "utf-8",        RTL_TEXTENCODING_UTF8        }
@@ -743,7 +745,7 @@
     { "sv",  RTL_TEXTENCODING_ISO_8859_1 }, 
     { "sw",  RTL_TEXTENCODING_ISO_8859_1 }, 
     { "ta",  RTL_TEXTENCODING_DONTKNOW }, 
-    { "th",  RTL_TEXTENCODING_DONTKNOW }, 
+    { "th",  RTL_TEXTENCODING_MS_874 }, 
     { "tr",  RTL_TEXTENCODING_ISO_8859_9 }, 
     { "tt",  RTL_TEXTENCODING_ISO_8859_5 }, 
     { "uk",  RTL_TEXTENCODING_ISO_8859_5 }, 
diff -urdP -X srcdiff.txt ../oo_1.0_src.orig/sal/textenc/tencinfo.c
sal/textenc/tencinfo.c
--- ../oo_1.0_src.orig/sal/textenc/tencinfo.c	Thu Feb 14 19:07:41 2002
+++ sal/textenc/tencinfo.c	Sun Jul 28 20:56:53 2002
@@ -464,6 +464,7 @@
         { "7", RTL_TEXTENCODING_ISO_8859_7 },
         { "8", RTL_TEXTENCODING_ISO_8859_8 },
         { "9", RTL_TEXTENCODING_ISO_8859_9 },
+
{ "11", RTL_TEXTENCODING_MS_874 },
         { NULL, RTL_TEXTENCODING_DONTKNOW }
     };
 
@@ -756,6 +757,7 @@
         { "iso885914", RTL_TEXTENCODING_ISO_8859_14 },
         { "iso885913", RTL_TEXTENCODING_ISO_8859_13 },
         { "iso885910", RTL_TEXTENCODING_ISO_8859_10 },
+
{ "iso885911", RTL_TEXTENCODING_MS_874 },
         { "iso88591", RTL_TEXTENCODING_ISO_8859_1 },
         { "iso88592", RTL_TEXTENCODING_ISO_8859_2 },
         { "iso88593", RTL_TEXTENCODING_ISO_8859_3 },
@@ -912,6 +914,8 @@
         { "gb18030", RTL_TEXTENCODING_GB_18030 },
             /* This is no actual MIME character set name, it's only a guess */
         { "big5hkscs", RTL_TEXTENCODING_BIG5_HKSCS },
+
{ "windows874", RTL_TEXTENCODING_MS_874 },
+
{ "tis620", RTL_TEXTENCODING_MS_874 },
         { NULL, RTL_TEXTENCODING_DONTKNOW }
     };
 
diff -urdP -X srcdiff.txt ../oo_1.0_src.orig/tools/source/inet/inetmime.cxx
tools/source/inet/inetmime.cxx
--- ../oo_1.0_src.orig/tools/source/inet/inetmime.cxx	Sat Oct 13 00:06:45 2001
+++ tools/source/inet/inetmime.cxx	Wed Jul 31 11:36:10 2002
@@ -1585,7 +1585,7 @@
 
			"IBM864", // RTL_TEXTENCODING_IBM_864
 
			"IBM866", // RTL_TEXTENCODING_IBM_866
 
			"IBM869", // RTL_TEXTENCODING_IBM_869
-
			0, // RTL_TEXTENCODING_MS_874
+
			"tis-620", // RTL_TEXTENCODING_MS_874
 
			"windows-1250", // RTL_TEXTENCODING_MS_1250
 
			"windows-1251", // RTL_TEXTENCODING_MS_1251
 
			"windows-1253", // RTL_TEXTENCODING_MS_1253
@@ -1841,6 +1841,7 @@
 
	{ "ISO-10646-UCS-4", RTL_TEXTENCODING_UCS4 },
 
	{ "CSUCS4", RTL_TEXTENCODING_UCS4 },
 
	{ "ISO-10646-UCS-2", RTL_TEXTENCODING_UCS2 },
+
	{ "TIS-620", RTL_TEXTENCODING_MS_874 }, // MIBenum: 2259
 
	{ "CSUNICODE", RTL_TEXTENCODING_UCS2 } };
 
 //============================================================================-
------ Additional comments from obr Wed Jul 31 22:16:42 -0700 2002 -------

I was told in i6659 that explicit support for TIS-620 has already been
added to 643 and head, so I wonder if these changes can be back-ported
to OOO_STABLE_1.------- Additional comments from er Sun Aug 4 07:57:08 -0700 
2002 -------

Furthermore, as TIS-620/iso5889-11 and MS-874 are not equal
encondings, this patch is wrong.

And please attach diffs/patches as a file to the issue instead of
pasting them into the comment field which breaks the diffs by
reformatting them and changing whitespace and whatever.
------- Additional comments from samphan Sun Aug 4 10:29:05 -0700 2002 -------

Sorry about pasting the patches :-(. I'm very new to IssueZilla and
didn't see the 'Create a new attchment' links before.

So, this is it for these patches. They're just simple hacks to support
Thai in OOo which we're using in our Thai version of OOo 1.0.1
(OfficeTLE). I understand that ignoring the differences between
TIS-620 and Windows-874 may pose some problems in the future such as
sending the wrong character to the internet.

Regarding TIS-620 vs Windows-874, please continue the discussion in
i6659. Thanks.
------- Additional comments from ms Wed Mar 12 07:08:07 -0700 2003 -------

As mentioned on the qa dev list on March 5th I will close all resolved
<wontfix/duplicate/worksforme/invalid> issues. Please see this posting for
details. First step in IssueZilla is unfortunately to set them to verified.-----
-- Additional comments from ms Wed Mar 12 07:32:32 -0700 2003 -------

As mentioned on the qa dev list on March 5th I will close all resolved
<wontfix/duplicate/worksforme/invalid> issues. Please see this posting for 
details. 
--------------------------------------------------------------------------------