i think we still want to have this place to modify the UDK version numbers and
the udkversion.mk file is a simple way to administrate this numbers independent
from the build environment. 

The file is hosted in sal because sal is the first "real" source module and we
want to have this information in place in all later built modules. Dependent on
the mk file we generate a header file in sal which is used in other mouldes
later and even in sal to generate library names dependent on the udk version number.

Why move it? I don't see any real benefit and all people who would maybe change
the version numbers know where it is and don't have to search anywhere else.

> Why move it?
Because this:

%udkversion.mk : $(PRJ)$/inc$/udkversion.mk
	@+$(COPY) $(PRJ)$/inc$/udkversion.mk $@
 
.INCLUDE .IGNORE : $(SOLARVERSION)$/$(INPATH)$/inc$(UPDMINOREXT)$/udkversion.mk

is done for every dmake call, and thanks to our current infrastructure
and use of build.pl that are quite a few. Basically the toplevel makefile tries
to do the job of the module and creates/delivers udkversion.mk. Why do we have
per module makefiles? Can't we move all comands to settings.mk?

So you always trigger the inference and then you ignore if it doesn't work.

Luckily sal is one of the first modules, so that the inference stopps early.
After that you just needlessly clutter the toplevel makefiles.

And all this for three variables that are defined in a non-standard,
undocumented location.

(IMHO these three variables should go into solarenv / <os>env.set )

ok i see, this rules are really nonsense i wasn't aware of them. I thought that
udkversion.mk is just delivered from sal. Under this circumstances i would agree
and we should move it into solenv/inc

A different approach would be to

.INCLUDE : $(PRJ)/inc/udkversion.mk
in sal before settings.mk and deliver the mk file normally.
In the place where the nonsense rule currently takes places
simply remove the .IGNORE and put an if around the inlcude

.IF "$(PRJNAME)"!="SAL"
.INCLUDE : $(SOLARVERSION)$/$(INPATH)$/inc$(UPDMINOREXT)$/udkversion.mk
.ENDIF

But of course moving the file into solenv/inc is probably the better or cleaner
solution.

> And all this for three variables that are defined in a non-standard,
undocumented location.
mmh, "non-standard, undocumented location" ... I am looking forward to a nicely
well documented overview of all variables, rules, ...  and a docu of the whole
build environment ;-)

So the question is open who will fix the issue. Do anybody of you have an
appropriate cws and can do it?

I complained, so I should fix it ;)

I would go with your

.IF "$(PRJNAME)"!="SAL"
.INCLUDE : $(SOLARVERSION)$/$(INPATH)$/inc$(UPDMINOREXT)$/udkversion.mk
.ENDIF

solution, but unfortunately sal is not the first module here, most often
the build starts with solenv and some external modules, so that would fail
without a .IGNORE .

So if you don't mind I'm going to move the file to solenv.

> mmh, "non-standard, undocumented location" ... I am looking forward to a
> nicely well documented overview of all variables, rules, ...  and a docu
> of the whole build environment ;-)

Oh, yeah! Me too ;-)

We should move it into solenv/inc to be save.

Created attachment 37474 [details]
Move udkversion.mk to solenv/inc

Done in vq33. Reassining for verification.

@jsc: Please verify.

Hmm, this failed in odk. Tesing this fix now:

+++ odk/util/makefile.pmk       4 Jul 2006 02:52:54 -0000
@@ -188,7 +188,7 @@
 INCLUDEDIRLIST:={$(subst,/,$/ $(shell $(FIND) $(INCLUDETOPDIRLIST) -type d -pri
nt))}
 
 INCLUDEFILELIST=\
-    $(INCOUT)$/udkversion.mk \
+    $(SOLARENV)$/inc$/udkversion.mk \
     $(INCOUT)$/com$/sun$/star$/uno$/Any.h \
     $(INCOUT)$/com$/sun$/star$/uno$/Any.hxx \
     $(INCOUT)$/com$/sun$/star$/uno$/genfunc.h \

Already committed to vq33. Build finished without further problems.

@jsc: Please verify.

all changes seems to be ok. Only one file was moved and a copy rule in the odk
module was adapted -> verified

closed