Apache OpenOffice (AOO) Bugzilla – Issue 67156
i18npool: warning: 'com::sun::star::i18n::table_CyrillicUpperLetter_bg' defined but not used
Last modified: 2006-07-14 16:40:12 UTC
In m175: ../../inc/bullet.h:399: warning: 'com::sun::star::i18n::table_CyrillicUpperLetter_bg' defined but not used ../../inc/bullet.h:407: warning: 'com::sun::star::i18n::table_CyrillicLowerLetter_bg' defined but not used ../../inc/bullet.h:415: warning: 'com::sun::star::i18n::table_CyrillicUpperLetter_ru' defined but not used ../../inc/bullet.h:423: warning: 'com::sun::star::i18n::table_CyrillicLowerLetter_ru' defined but not used dmake: Error code 1, while making '../../unxlngi6.pro/slo/numtotext_cjk.obj' '---* tg_merge.mk *---' ERROR: Error 65280 occurred while making /disk3/oo/BuildDir/ooo_SRC680_m175_src/i18npool/source/transliteration oo@oo:~/BuildDir/ooo_SRC680_m175_src/i18npool> Eike, is it OK to fix it this way (simply moving #endif to the end of the file)? diff -urN ooo_SRC680_m175_src.orig/i18npool/inc/bullet.h ooo_SRC680_m175_src/i18npool/inc/bullet.h --- ooo_SRC680_m175_src.orig/i18npool/inc/bullet.h 2006-07-09 15:31:10.000000000 +0200 +++ ooo_SRC680_m175_src/i18npool/inc/bullet.h 2006-07-09 15:35:42.000000000 +0200 @@ -393,8 +393,6 @@ 0x0F62, 0x0F63, 0x0F64, 0x0F66, 0x0F67, 0x0F68 }; -#endif - // Bulgarian Cyrillic upper case letters static sal_Unicode table_CyrillicUpperLetter_bg[] = { 0x0410, 0x0411, 0x0412, 0x0413, 0x0414, 0x0415, 0x0416, 0x0417, 0x0418, @@ -427,4 +425,6 @@ 0x0449, 0x044B, 0x044D, 0x044E, 0x044F }; +#endif + } } } } BTW - it would be much easier to move these tables away from bullet.h to i18ntables.h or something like this to prevent such problems in the past.
.
obo: I do not like the solution you introduced in 1.15 of this file. Please have a look at the proposed patch.
obo: your solution even breakes the compilation on Mac OS X: Making: ../../unxmacxp.pro/slo/numtotext_cjk.obj /Users/oo/BuildDir/bin/ccache /usr/bin/g++ -fsigned-char -fmessage-length=0 -malign-natural -c -O2 -fno-strict-aliasing -I. -I../../unxmacxp.pro/inc/transliterationImpl -I../inc -I../../inc -I../../unx/inc -I../../unxmacxp.pro/inc -I. -I/Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/solver/680/unxmacxp.pro/inc/stl -I/Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/solver/680/unxmacxp.pro/inc/external -I/Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/solver/680/unxmacxp.pro/inc -I/Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/solenv/unxmacxp/inc -I/Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/solenv/inc -I/Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/res -I/Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/solver/680/unxmacxp.pro/inc/stl -I/System/Library/Frameworks/JavaVM.framework/Versions/Current/Headers -I/System/Library/Frameworks/JavaVM.framework/Headers -I/usr/X11R6/include/ -I/usr/X11R6/include//freetype2 -I/Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/solver/680/unxmacxp.pro/inc/offuh -I. -I../../res -I. -pipe -malign-natural -fsigned-char -Wno-long-double -Wno-ctor-dtor-privacy -fexceptions -fno-enforce-eh-specs -fPIC -fno-common -DMACOSX -DUNX -DVCL -DGCC -DC300 -DPOWERPC -DCVER=C300 -DGLIBC=2 -D_PTHREADS -D_REENTRANT -DNO_PTHREAD_PRIORITY -DPOWERPC -DPPC -DSTLPORT_VERSION=400 -D_USE_NAMESPACE=1 -DX_LOCALE -DHAVE_GCC_VISIBILITY_FEATURE -DNO_AUDIO -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -DGXX_INCLUDE_PATH=/usr/include/gcc/darwin/4.0/c++ -DSUPD=680 -DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DEXCEPTIONS_ON -DCUI -DSOLAR_JAVA -DSRC680=SRC680 -DBUILD_OS_APPLEOSX -DBUILD_OS_MAJOR=10 -DBUILD_OS_MINOR=4 -DBUILD_OS_REV=7 -DSHAREDLIB -D_DLL_ -DMULTITHREAD -o ../../unxmacxp.pro/slo/numtotext_cjk.o /Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/i18npool/source/transliteration/numtotext_cjk.cxx /Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/i18npool/source/transliteration/numtotext_cjk.cxx:98: error: 'table_CyrillicUpperLetter_bg' was not declared in this scope /Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/i18npool/source/transliteration/numtotext_cjk.cxx:99: error: 'table_CyrillicLowerLetter_bg' was not declared in this scope /Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/i18npool/source/transliteration/numtotext_cjk.cxx:100: error: 'table_CyrillicUpperLetter_ru' was not declared in this scope /Volumes/Build/oo/BuildDir/ooo_SRC680_m176_src/i18npool/source/transliteration/numtotext_cjk.cxx:101: error: 'table_CyrillicLowerLetter_ru' was not declared in this scope
Hi Pavel, thanks for the patch, I've commited it on the mws. Oliver
Verified, closing.
Just a comment: > BTW - it would be much easier to move these tables away from bullet.h to > i18ntables.h or something like this to prevent such problems in the past. In CWS 'icuupgrade' Karl moved the definitions to the implementation .cxx file as it is the only place where they are used now.