Issue 67558 - neon must not deliver private header config.h
Summary: neon must not deliver private header config.h
Status: CLOSED FIXED
Alias: None
Product: ucb
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.x
Assignee: hjs
QA Contact: issues@ucb
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-19 13:50 UTC by hjs
Modified: 2007-07-13 14:56 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hjs 2006-07-19 13:50:02 UTC 
as written in #i64798# the cleaner solution to determin the neon version is to
use the version supplied in config.h of neon itself.
please do not forget to remove setting NEON_VERSION in config_office and ssrc680.ini
Comment 1 kai.sommerfeld 2006-07-20 08:02:58 UTC 
The cleaner solution suggested in #i64798# does actually not work. I overlooked
that config.h is not a public neon header file, but it gets delivered by
neon/makefile.mk. Even worse, there is actually no need for doing this. None of
the projects using neon is using config.h 

Remove config.h delivery from neon/makefile.mk
Comment 2 kai.sommerfeld 2006-07-20 08:03:45 UTC 
.
Comment 3 kai.sommerfeld 2006-07-20 08:04:25 UTC 
.
Comment 4 hjs 2006-07-20 11:35:08 UTC 
so there is still the option to generate some "neon_version.mk" to have
propagating the version for the supplied neon close to the tarball and not
hidden somewhere in solenv/config
Comment 5 kai.sommerfeld 2007-04-25 15:06:00 UTC 
Fixed in CWS ucbfixes01. 

solenv no longer defines NEON_VERSION. config_office only defines NEON_VERSION
for system neon. neon defines NEON_VERSION for internal neon. ucb uses
neon-supplied NEON_VERSION for internal builds, config_office supplied
NEON_VERSION for system builds.

neon does no longer deliver config.h

solenv/config/ssrc680.ini r1.120.28.1
config_office/configure r1.181.10.1
neon/version.mk r1.1.2.1
neon/prj/d.lst r1.1.152.1
ucb/source/ucp/webdav/makefile.mk r1.32.4.2
Comment 6 rene 2007-04-25 15:59:33 UTC 
reopen.

configure is a generated file and so the next time it will be generated the
change would be lost (that it would break something, but still..)

configure.in needs to be changed, too
Comment 7 kai.sommerfeld 2007-04-26 09:38:15 UTC 
kso->rene: Thanks for pointing this out. 

Fixed.

config_office/configure.in r1.198.8.1
Comment 8 kai.sommerfeld 2007-05-03 14:20:40 UTC 
kso->hjs: Please verify.
Comment 9 hjs 2007-05-03 15:21:49 UTC 
.
Comment 10 hjs 2007-07-13 14:56:35 UTC 
.