Issue 67589 - Implement internal dmake commands noop and echo
Summary: Implement internal dmake commands noop and echo
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-20 03:33 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Only FIXMEs (1.29 KB, patch)
2006-07-20 03:48 UTC, quetschke 		no flags Details | Diff
Patch for dmake (6.11 KB, patch)
2006-07-27 02:56 UTC, quetschke 		no flags Details | Diff
Patch for dmake (6.25 KB, patch)
2006-07-28 22:13 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-07-20 03:33:30 UTC 
This might not be a problem, but if the last recipe line of a target is empty or
whitespace only and there were valid recipe lines before in that target than
it is possible that that Update_time_stamp() is called in Do_cmnd() before the
previous recipe has finished.

(This is not a problem if there are only empty recipe lines, like the $(not ...)
construction from issue 66651.)
Comment 1 quetschke 2006-07-20 03:48:37 UTC 
Created attachment 37903 [details]
Only FIXMEs
Comment 2 quetschke 2006-07-27 02:56:53 UTC 
Created attachment 38059 [details]
Patch for dmake
Comment 3 quetschke 2006-07-27 03:24:14 UTC 
Changing title, this issue is not only about "Skipping empty recipe lines might
result in calling Update_time_stamp() too early but about cleaning the process
up a little and implementing internal dmake commands noop and echo. These already
exist for the native Windows version.
Comment 4 quetschke 2006-07-28 22:13:29 UTC 
Created attachment 38124 [details]
Patch for dmake
Comment 5 quetschke 2006-07-28 22:20:18 UTC 
Committed previous patch to dmake46.

Testcase and documentation are still to be done.
Comment 6 quetschke 2006-07-30 02:55:58 UTC 
Committed documentation and testcases to dmake46.
Comment 7 quetschke 2006-07-30 02:56:25 UTC 
@ause: Please verify
Comment 8 hjs 2006-09-14 16:47:09 UTC 
.
Comment 9 hjs 2006-09-14 17:22:57 UTC 
.
Comment 10 hjs 2007-01-03 12:03:59 UTC 
.