Issue 68668 - saldisp.cxx:565: error: 'class SalData' has no member named 'GetLib'
Summary: saldisp.cxx:565: error: 'class SalData' has no member named 'GetLib'
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.0.4
Assignee: philipp.lohmann
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-16 11:58 UTC by pmladek
Modified: 2006-08-23 12:19 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Proposed fix (685 bytes, patch)
2006-08-16 11:59 UTC, pmladek 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pmladek 2006-08-16 11:58:30 UTC 
I got the following two build errors with ood680-m1:

--- cut ---
/usr/src/packages/BUILD/ooo-build-src680-m180c/build/ood680-m1/vcl/unx/source/app/saldisp.cxx:
In function 'void SnErrorTrapPush(SnDisplay*, Display*)':
/usr/src/packages/BUILD/ooo-build-src680-m180c/build/ood680-m1/vcl/unx/source/app/saldisp.cxx:565:
error: 'class SalData' has no member named 'GetLib'
/usr/src/packages/BUILD/ooo-build-src680-m180c/build/ood680-m1/vcl/unx/source/app/saldisp.cxx:
In function 'void SnErrorTrapPop(SnDisplay*, Display*)':
/usr/src/packages/BUILD/ooo-build-src680-m180c/build/ood680-m1/vcl/unx/source/app/saldisp.cxx:574:
error: 'class SalData' has no member named 'GetLib'
--- cut ---

It seems that someone forgot to modify two locations during the SalData ->
X11SalData change. The problem is visible only if you build with libsn.

I'll attach a patch for it.

I could create CWS if you approve the fix. I think that it should go to
OOo-2.0.4, definitely.
Comment 1 pmladek 2006-08-16 11:59:16 UTC 
Created attachment 38550 [details]
Proposed fix
Comment 2 pmladek 2006-08-16 11:59:50 UTC 
Set target to OOo-2.0.4.
Comment 3 jens-heiner.rechtien 2006-08-16 17:18:13 UTC 
The patch is approved. Please create a CWS inclusion in OOD680 m2. I was
wondering why this didn't show up in my build but I see that the code is
conditional with HAVE_LIBSN, so no wonder here.
Comment 4 pmladek 2006-08-16 19:14:47 UTC 
The patch is in CWS pmladek04 in MWS OOD680 now => FIXED

hr: Could I set you as the QA person?
Comment 5 jens-heiner.rechtien 2006-08-17 16:19:51 UTC 
I've already made myself QA rep for the CWS :-)

Issue verified.
Comment 6 jens-heiner.rechtien 2006-08-23 12:19:00 UTC 
Close issue.