Issue 68888 - Avoid too long lines in ddf files
Summary: Avoid too long lines in ddf files
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: configure (show other issues)
Version: current
Hardware: PC Windows, all
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: ingo.schmidt-rosbiegal
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-23 14:28 UTC by tml
Modified: 2007-12-11 11:45 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Same patch as an attachment (1.69 KB, patch)
2006-08-23 14:29 UTC, tml
no flags Details | Diff
Use relative paths in ddf files. It will create much sorter paths in the ddf files. (1.46 KB, patch)
2007-11-16 16:33 UTC, kami911
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description tml 2006-08-23 14:28:06 UTC
If your TMP (or is it TEMP?) is too long (for instance something like
"C:\DOCUME~1\TORLIL~1\LOCALS~1\Temp"), you get an error in instsetoo_native when
building the OpenOffice_SDK: "Lines in ddf files must not contain more than 256
characters!". To avoid this one should use a shorter path for TMP and TEMP. A
typical path would be c:\tmp. The below straightforward patch attempts that.

--- config_office/configure.in
+++ config_office/configure.in
@@ -5242,6 +5242,32 @@
 
 AC_SUBST(BUILD_TYPE)
 
+if test "$_os" = "WINNT"; then
+    # Set TMP (and TEMP) to a short value to avoid potential problems with
+    # too long lines in ddf files
+    AC_MSG_CHECKING([for problematic length of TMP and TEMP])
+    # $TMP and $TEMP are usually the same, but just to be sure...
+    # and I am not sure which one actually gets used
+    case "`cygpath -w $TMP`!`cygpath -w $TEMP`" in
+    ??????????*!*|*!????????*)
+	# Either is "long", try using "C:\tmp"
+	AC_MSG_RESULT([yes])
+	mkdir /cygdrive/c/tmp 2>/dev/null
+	if test -d /cygdrive/c/tmp && touch /cygdrive/c/tmp/foobarzap 2>/dev/null; then
+	    rm /cygdrive/c/tmp/foobarzap
+	    TEMPORARY_DIRECTORY=/cygdrive/c/tmp
+	    AC_SUBST(TEMPORARY_DIRECTORY)
+	    echo Using `cygpath -w $TEMPORARY_DIRECTORY`
+	else
+	    AC_MSG_WARN([One or both are too long, but can't figure out what to use
instead])
+	fi
+	;;
+   *)
+	AC_MSG_RESULT([no])
+	;;
+    esac
+fi
+
 # make sure config.guess is +x; we execute config.guess, so it has to be so; 
 chmod +x $_solenv/bin/config.guess
 
dummy line to avoid confusing diff-mode
--- config_office/set_soenv.in
+++ config_office/set_soenv.in
@@ -1660,6 +1660,10 @@
    ToFile( "ENABLE_VCTK",       "@ENABLE_VCTK@",    "e" );
    ToFile( "NETTOOLKIT",        "@NETTOOLKIT@",     "e" );
    ToFile( "USE_NEW_SDK",       $USE_NEW_SDK,       "e" );
+   if( '@TEMPORARY_DIRECTORY@' ) {
+      ToFile( "TMP",            "@TEMPORARY_DIRECTORY@", "e");
+      ToFile( "TEMP",           "@TEMPORARY_DIRECTORY@", "e");
+   }
 }
 ToFile( "PERL",              $PERL,              "e" );
 ToFile( "RPM",               "@RPM@",            "e" );
Comment 1 tml 2006-08-23 14:29:51 UTC
Created attachment 38722 [details]
Same patch as an attachment
Comment 2 pavel 2006-08-23 17:36:32 UTC
This is duplicate to #i59187#, isn't it?
Comment 3 tml 2006-08-23 17:58:17 UTC
If you say so. That means there is little chance of this patch getting accepted,
doesn't it, sigh ;) 
Comment 4 dridgway 2007-01-02 17:33:03 UTC
Marking duplicate as per comments.

*** This issue has been marked as a duplicate of 59187 ***
Comment 5 kami911 2007-11-16 16:33:24 UTC
Created attachment 49697 [details]
Use relative paths in ddf files. It will create much sorter paths in the ddf files.
Comment 6 kami911 2007-11-17 09:02:56 UTC
IS: Can you please take over and check the provided new patch?

Thank you.
Comment 7 kami911 2007-11-17 09:05:36 UTC
I think it is a more general issue not only fo SDK. That is why I did not open
another (new) issue.
Comment 8 ingo.schmidt-rosbiegal 2007-11-19 09:49:39 UTC
Target OOo 2.4
Comment 9 ingo.schmidt-rosbiegal 2007-11-19 09:50:22 UTC
.
Comment 10 ingo.schmidt-rosbiegal 2007-11-22 13:45:07 UTC
reassigning
Comment 11 ingo.schmidt-rosbiegal 2007-11-23 10:28:07 UTC
accepting
Comment 12 ingo.schmidt-rosbiegal 2007-11-23 11:02:23 UTC
Using RELATIVE_PATHES_IN_DDF for all products in openoffice.lst
-> Fixed.
Comment 13 ingo.schmidt-rosbiegal 2007-11-30 10:55:49 UTC
Verified in cws native120.
Comment 14 ingo.schmidt-rosbiegal 2007-12-11 11:45:45 UTC
Integrated into master (m239) -> closing issue.