Issue 69071 - umask makes no sense for DOS filesystems
Summary: umask makes no sense for DOS filesystems
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All Windows, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-29 18:03 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (1.84 KB, patch)
2006-08-29 18:05 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-08-29 18:03:42 UTC 
Issue generated from Steve's email:

-- snip --
I checked this out and found that it has compilation errors in function.c (line
322) and sysintf.c (line 667) due to VC++ not having a mode_t type.  The st_mode
member of a struct stat seems to be simply an unsigned short in VC++ (in version
6, at least).

It compiles cleanly after I changed mode_t to unsigned short, but I'll let you
decide exactly what change you'd rather make before I start testing.
-- snap --

Setting umask in MSVC is useless as it only sets the rights for the current
process (user?). The following patch disables setting umask for native W32
builds.
Comment 1 quetschke 2006-08-29 18:05:43 UTC 
Created attachment 38838 [details]
Patch for dmake
Comment 2 quetschke 2006-08-29 18:08:43 UTC 
Committed to dmake46
Comment 3 hjs 2006-09-14 14:45:15 UTC 
.
Comment 4 quetschke 2006-11-01 18:30:07 UTC 
close