Issue 69510 - Disalow assigning to (, {, :, ), } macro names
Summary: Disalow assigning to (, {, :, ), } macro names
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on: 80547
Blocks:
  Show dependency tree
 
Reported: 2006-09-13 19:19 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (1.60 KB, patch)
2007-08-08 17:50 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-09-13 19:19:56 UTC 
This is a follow up for issue 44961:

while usage of (, : and { as single char variables is chatched now, it's still
possible to assign values to it:

{ := ppp
( := ppp
: := ppp
# this one is an error with 4.6 / 4.5
#bla1=$(assign ( = ttt )
bla2:=$(assign { = ttt )
bla3:=$(assign : = ttt )
Comment 1 quetschke 2007-08-08 17:50:45 UTC 
Created attachment 47397 [details]
Patch for dmake
Comment 2 quetschke 2007-08-08 18:54:59 UTC 
Committed + testcase to dmake411.
Comment 3 quetschke 2007-08-08 18:55:25 UTC 
Please verify
Comment 4 quetschke 2007-08-09 20:46:58 UTC 
This patch also added an additional check for assignments to empty macro names.
Making this an error was not a good idea as this feature is used in some places.
See issue 80547 for details.

Change the error to a warning for now, but depending on issue 80547 we might
choose a different solution.
Comment 5 quetschke 2007-09-16 18:28:36 UTC 
I think a warning is good enough here, but depending on issue 80547 we can easily
make it an error later.

Please comment/verify
Comment 6 hjs 2007-10-02 10:42:58 UTC 
.
Comment 7 hjs 2007-12-21 13:39:28 UTC 
dmake 4.11 is in use now