Issue 69743 - Optimize $(subst,pat,rep bla)
Summary: Optimize $(subst,pat,rep bla)
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-21 16:55 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-09-21 16:55:13 UTC 
Currently we have a lot of $(subst,/,$/ bla) in the OOo makefiles. Except for
W32-4nt builds this means we are replacing / with /.

We should add a shortcut to expand.c:Apply_edit() to stop this nonsense.

Thanks Matthias, for the profiling and the patch.

P.S.: The rest of Apply_edit() is just horribly inefficient and would warrant
a follow up issue to optimize it.
Comment 1 quetschke 2006-09-21 17:28:07 UTC 
Committed.

@ause: Please verify.
Comment 2 hjs 2006-09-22 09:46:32 UTC 
.
Comment 3 hjs 2007-01-03 12:03:39 UTC 
.