Issue 69821 - dmake macro TMD has more problems
Summary: dmake macro TMD has more problems
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-24 23:02 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (2.07 KB, patch)
2006-09-24 23:23 UTC, quetschke 		no flags Details | Diff
Testcase for dmake (1.23 KB, patch)
2006-09-24 23:24 UTC, quetschke 		no flags Details | Diff
Patch for dmake/make.c (6.27 KB, patch)
2006-11-09 20:20 UTC, quetschke 		no flags Details | Diff
New patch - fixing testsuite regression (7.45 KB, patch)
2006-11-09 21:15 UTC, quetschke 		no flags Details | Diff
Drive letters are case insensitive ... (7.20 KB, patch)
2006-11-09 22:25 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-09-24 23:02:11 UTC 
The following two minor problems were not fixed in issue 61170:

1) This makefile:
---
all :
	@+echo "TMD:$(TMD):"
---
Results in:
TMD::
but TMD should be '.'.

2) This makefile:
---
SHELL*:=/bin/sh 
SHELLFLAGS*:=-ce

all .SETDIR=../../test2/aaa :
	@+echo "TMD:$(TMD):"
---

Produces the wrong result for TMD in this configuration:
$ mkdir -p test1/aaa
$ mkdir -p test2/aaa
$ cd test1/aaa/ ; dmake.exe -rf ../../t_tmd_2.mk
TMD:../test1:

Correct would be: TMD="../test1/aaa"
Comment 1 quetschke 2006-09-24 23:23:09 UTC 
Created attachment 39334 [details]
Patch for dmake
Comment 2 quetschke 2006-09-24 23:24:00 UTC 
Created attachment 39335 [details]
Testcase for dmake
Comment 3 quetschke 2006-09-24 23:25:06 UTC 
I'm waiting for dmake47 ... ;)
Comment 4 quetschke 2006-09-28 22:43:55 UTC 
Committed, but I found another TMD problem (with absolute DOS paths).
Comment 5 quetschke 2006-11-09 20:20:48 UTC 
Created attachment 40474 [details]
Patch for dmake/make.c
Comment 6 quetschke 2006-11-09 21:15:48 UTC 
Created attachment 40478 [details]
New patch - fixing testsuite regression
Comment 7 quetschke 2006-11-09 21:45:00 UTC 
The TMD problem with absolute DOS paths can be verified for W32 native builds
with this makefile:

--- makefile.mk ---
SHELL:=cmd.exe 
SHELLFLAGS:=/C

# Make TEMP the target directory, cd to TMD should go back to
# the original directory
all ".SETDIR=c:/temp" :
	@+echo TMD:$(TMD):
--- makefile.mk ---

[in cmd.exe window, working directory on different drive letter]
D:\w1\cws_src680_dmake47>dmake\dmake.exe -rf t_69821_4.mk
TMD:D:\w1\cws_src680_dmake47:
Comment 8 quetschke 2006-11-09 22:25:55 UTC 
Created attachment 40481 [details]
Drive letters are case insensitive ...
Comment 9 quetschke 2006-11-09 22:34:16 UTC 
Patch and testcase committed to dmake47.

Please verify.
Comment 10 hjs 2007-01-16 12:49:18 UTC 
ok
Comment 11 hjs 2007-01-23 14:35:38 UTC 
seen in MWS