Issue 69889 - [a11y] Table Wizard panel has several inaccessible components.
Summary: [a11y] Table Wizard panel has several inaccessible components.
Status: CLOSED FIXED
Alias: None
Product: Base
Classification: Application
Component: code (show other issues)
Version: OOo 2.0.4
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: lars.langhans
QA Contact: issues@dba
URL:
Keywords: accessibility
Depends on:
Blocks: 20748 90510
  Show dependency tree
 
Reported: 2006-09-26 20:15 UTC by richburridge
Modified: 2009-07-19 18:28 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description richburridge 2006-09-26 20:15:58 UTC
See also GNOME bug #357545 reported against Orca.
http://bugzilla.gnome.org/show_bug.cgi?id=357545

Steps to reproduce:

* Startup Orca
* Startup sbase for the first time. A wizard dialog will
  appear.
* Select the radio button for "Create a new database" and click Next
* Click the checkbox for "Create Tables Using the Tables Wizard" and
  click Finish.
* The "Save As" dialog appears. Select a name for the database and click
  Save.
* The "New Database" window appears plus the Table Wizard.
* On this first panel (select fields for your table)
  there are several buttons:
  [ > ]
  [ >> ]
  [ < ]
  [ << ]
  [ ^ ]
  [ v ]
  which do not have useful accessible descriptions. A blind user would not
  know what they are for.
* On the second panel (set field types and formats), there
  are several more buttons:
  [ ^ ]
  [ v ]
  [ - ]
  [ + ]
  which do not have accessible descriptions.
  The text field in the top right does not have a LABELLED_BY relationship
  with the "Field name" label.

And so on.

I suggest that somebody go through this complete dialog making sure
all the components have accessible information associated with them.
Comment 1 christoph.lukasiak 2006-10-10 15:44:44 UTC
clu->obr: like i agreed with es this is a rather general problem by design, that
we have in many different places in the office (especially in wizards) where we
use arrow symbols etc. and a reader reads things like: 'greater than, greater
than' - this happens with zoom text, too. please make a final decision for such
cases and let us known about, because this seems to be an application
independent problem.

thx
Comment 2 christoph.lukasiak 2006-10-10 15:45:49 UTC
set to 'new'
Comment 3 nospam4obr 2006-10-11 12:19:42 UTC
I have submitted several RFEs to introduce those buttons in VCL / UNO toolkit
and also issue 70296 to have a generic interface to manually override the
default accessibility information for UI implemented using the UNO toolkit.

It should already be possible to set the missing LABELLED_BY relations using the
UNO Accessiblity API now.
Comment 4 berend.cornelius 2006-10-12 14:42:45 UTC
Basically I set the AccessibilityName at the VCLWindowPeer for all these
controls and this always worked fine.
So this issue is broken. I will consult MT how to go on with this issue
Comment 5 berend.cornelius 2006-10-12 14:51:49 UTC
.
Comment 6 berend.cornelius 2007-02-01 15:13:44 UTC
bc: Setting target to OOo2.3
Comment 7 berend.cornelius 2007-07-23 13:27:59 UTC
bc: resetting target to OOo 2.x
Comment 8 berend.cornelius 2007-07-23 13:31:07 UTC
bc->obr: I set the AccessibilityName but it seems that this is not passed
through to the screenreader.
Comment 9 nospam4obr 2007-08-09 11:14:35 UTC
obr->bc: please read the bug description again: this is about the accessible
description, not the accessible name (even though I did not know about the
existing property approach in UNO AWT initially).

* on the first panel, the description of the first 4 buttons mentioned is:
  "Displays all fields that will be included in the new table", which seems to 
   be the description of the panel.

  Button [ ^ ], [ V ] look good to me though.

* on the second panel, the description of the first 2 buttons mentioned is:
  "The table wizard helps you to create a database table". The same text is 
  used for [ Next ], [ Back ], [ Finish ], [ Cancel ].

  Button [ - ], [ + ] look good to me again and even the LABELLED_BY relation     
  is there now.

All this seen on a CWS based SRC680 m215.

The source of the problem seem to be wrong/missing help ids for those buttons in
wizards/com/sun/star/wizards/ui/fieldselection.java line 212
(thanks to OJ for identifying the problem).
Comment 10 berend.cornelius 2008-01-03 12:40:44 UTC
I once again verified the help-ids of all controls in question and could not
detect anything wrong about it. So as far as I can see my implementation
contains valid  help-ids and valid AccessibilityNames. What else am I to do?
Comment 11 nospam4obr 2008-01-03 16:13:44 UTC
The Online Help displayes e.g. the following string for the [ >> ] button:

"Click to move all fields to the box the arrow is pointing to."

A search in helpcontent2 for this string reveals:

helpcontent2/source/text/shared/autopi/01090100.xhp
helpcontent2/source/text/shared/autopi/01100100.xhp

AB, MT, UFI: can anyone of you shed some light on why the Online Help is able to
find the correct text for those buttons and the toolkit implementation of
AccessibleDescription is not ?
Comment 12 Uwe Fischer 2008-01-04 13:14:42 UTC
Ufi's comment: I don't know about the AccessibleDescription texts. Berend might
know. 
The text you quoted is part of the extended help text for the controls. I
changed those texts due to issue 73704 in May 2007. The changes got integrated
in September 2007.
Comment 13 berend.cornelius 2008-01-08 14:43:12 UTC
bc->cd: As discussed -> to you
Comment 14 carsten.driesner 2008-01-09 16:05:17 UTC
cd: Changed target.
Comment 15 carsten.driesner 2008-01-10 08:22:01 UTC
cd: As this is an important accessibility issue set target to next upcoming
release (OOo 3.0).
Comment 16 carsten.driesner 2008-02-01 16:14:00 UTC
cd: Accepted.
Comment 17 carsten.driesner 2008-05-29 15:28:39 UTC
cd: The current state of this issue is:
There are accessible descriptions for the table wizard controls, but some of
them have definitely wrong descriptions. It's also strange that most of them
share a single description from the "Selected Items" control. All controls have
a help ID so there must be a mapping problem between help ID and help text or
wrong help text. At least I cannot find a problem within the toolkit/vcl
implementation. Even the extended help for this dialog uses the wrong help texts
for the controls. LLA and I will clarify the root cause for the wrong help
text/accessible description.
Comment 18 Uwe Fischer 2008-05-29 16:06:25 UTC
AFAIK the extended help text has absolutely nothing to do with the
AccessibilityName and AccessibilityDesciption. So don't look at the extended
help text with regard to this accessibility issue.
Comment 19 Uwe Fischer 2008-05-29 16:11:39 UTC
You write "Even the extended help for this dialog uses the wrong help texts
for the controls. LLA and I will clarify the root cause for the wrong help
text/accessible description."
The help file is text/shared/explorer/database/tablewizard01.xhp, and the reason
for the wrong help texts is well known. It is NOT related to accessibility. It
is http://www.openoffice.org/issues/show_bug.cgi?id=48946 and obviously I
overlooked this file - will fix that in the next CWS.
Comment 20 carsten.driesner 2008-05-29 16:38:18 UTC
cd->ufi: Uwe, the current implementation within the Window base class uses the
function GetHelpText() for the accessible description. That's a fact. Please
look at the implementation yourself.

String Window::GetAccessibleDescription() const
{
	String aAccessibleDescription;
	if ( mpWindowImpl->mpAccessibleInfos &&
mpWindowImpl->mpAccessibleInfos->pAccessibleDescription )
	{
		aAccessibleDescription = *mpWindowImpl->mpAccessibleInfos->pAccessibleDescription;
	}
	else
	{
		// Special code for help text windows. ZT asks the border window for the
		// description so we have to forward this request to our inner window.
		const Window* pWin = ((Window *)this)->ImplGetWindow();
		if ( pWin->GetType() == WINDOW_HELPTEXTWINDOW )
			aAccessibleDescription = pWin->GetHelpText();
		else
			aAccessibleDescription = GetHelpText();
	}

	return aAccessibleDescription;
}
Comment 21 carsten.driesner 2008-05-30 06:36:45 UTC
cd->lla: Please take over. I think this issue is now only dependent on 48946
which must be fixed by ufi.
Comment 22 Uwe Fischer 2008-05-30 06:58:41 UTC
So thank you for telling me that extended help text is used for accessibility
texts. No one ever told me before.
Issue 48946 is set to WONTFIX. I cannot do any string changes for 3.0 any more,
next changes will be for target 3.1.
Comment 23 Uwe Fischer 2008-06-04 15:07:31 UTC
Will fix assignment of Help IDs in CWS hcshared19, issue 48946
Comment 24 lars.langhans 2008-06-18 10:11:35 UTC
Found out the real problem:
There was used 'AccessibilityName' instead of the right 'AccessibleName'
property, now it works like a charme.

@ufi, nothing to be done for translation, because all texts are there.

There exist no CWS to insert, because I'm having to wait for rptwizard01 to be
integrated in the MWS so please be patient.
Comment 25 lars.langhans 2008-07-01 12:50:15 UTC
fixed
Comment 26 eric.savary 2008-07-03 15:39:04 UTC
Verified.

AccessibleName corrected but Orca (2.20.1) still reads "greater then" because it
is the accessibleTetx.
Comment 27 lars.langhans 2008-07-03 16:04:13 UTC
The wizard sets the 'AccessibleName' property, which is of the 'greater than'
button: 'Add field'.

The other values are:
'Add all fields'
'Remove field'
'Remove all fields'
'Move field up'
'Move field down'
Comment 28 richburridge 2008-07-03 17:50:25 UTC
Orca v2.20.2 is quite old in terms of Orca development.

Any chance you could verify these bugs against the latest version of Orca?
You can either get this from trunk in the SVN repository, or via tarball.
The last tarball released version is Orca 2.23.4. 

See:
http://ftp.gnome.org/pub/GNOME/sources/orca/2.23/

See also:
http://live.gnome.org/Orca/DownloadInstall

for more details on how to download and install Orca.

Thanks.
Comment 29 lars.langhans 2008-07-09 14:26:53 UTC
ok, I have installed the new orca 2.23.4 on my linux but it stops working after
short period of time due to an unknown problem:

Orca watchdog detected something bad. Cleaning up.
/usr/bin/orca: line 92:  5109 GOrca watchdog detected something bad. Cleaning up.
/usr/bin/orca: line 92:  5109 Getötet                /usr/bin/python -c "import
orca.orca; orca.orca.main()" "$ARGS"
etötet                /usr/bin/python -c "import orca.orca; orca.orca.main()"
"$ARGS"

Maybe I need Gnome desktop, @the moment I use KDE.

- Also I don't know what really to do, to get orca working together with soffice. 
- I checked with gconf-editor that in Desktop - Gnome - Interface the a11y
checkbox is checked.
- But Orca don't show any A11Y information after soffice is started.
Comment 30 richburridge 2008-07-09 16:11:53 UTC
Yes, you will need to be running GNOME. 

Orca will try to speak/braille the application that currently has focus.
If that is soffice, you then use the keyboard to navigate to the various
components that are being shown. That is why keyboard navigation of all
areas is so important, and one would hope obvious, to the Orca users.

There are also various keyboard shortcuts, to move around the GNOME
desktop etc.
Comment 31 lars.langhans 2008-07-10 14:24:11 UTC
I have done installed Gnome and also start it. With started orca I see lot of
text in the 'window mode' braille line if office is start.

Is it normal that I see something like 'knpf' instead of 'knopf' or 'dlg'
instead of dialog?

Also '> knpf' is coming on the Wizard Button, therefore orca is not be able to
show the 'AccessibleName' property content as expected. It use something else :-(

Also it is useless that I have to use Gnome, due to the fact I hate Gnome (this
had historical reasons), I love KDE and all tools which don't be able to run in
KDE environment are useless tools.
Comment 32 williewalker 2008-07-16 17:56:27 UTC
>Is it normal that I see something like 'knpf' instead of 
>'knopf' or 'dlg' instead of dialog?

In looking at the German translation file, I see that "knpf" is the short
braille for the push button rolename and "Schaltfläche" is the long braille.  By
default, Orca should use the long braille for rolenames, and I just verified it
seems to be doing so.  Did you make any changes in your Orca preferences to use
short braille for rolenames?  It would be in the "Braille" tab of the Orca
preferences GUI.

>Also '> knpf' is coming on the Wizard Button, therefore orca is not be 
>able to show the 'AccessibleName' property content as expected. It use
>something else :-(

We have made the general rule of thumb that if there is accessible text being
presented by an object, Orca presents that text since it is a *screen* reader.
There has been some discussion about giving priority to the accessible name if
it exists (which is what you've done in this case -- thanks!), but we have run
into cases where the accessible name is programmatic garbage.  As such, we've
been better off giving priority to the accessible text instead.

I'll talk about alternative approaches with our UI person. Some options might
include:

1) Using images instead of text for the buttons in question.  With this, Orca
will fallback to the accessible name, which is the main reason accessible name
exists.

2) Making the new strings accessible descriptions or tooltips that the user can
get to via Ctrl+F1 when then button has focus and/or via Orca's "Where Am I"
functionality.
Comment 33 williewalker 2008-07-18 13:13:28 UTC
In discussing this with our UI designer (who is also a user), the preferred
method would be to not use text characters for representing arrows.  Instead,
images with accessible names/descriptions would be preferred.

Failing that, Orca is a screen reader and will read the text being presented to
the user.  We appreciate the addition of the accessible names, however, but
kindly request that the given strings be used for the accessible description of
the object instead of the accessible name.  With this, the Orca user will be
presented with the visual text that sighted users see and they can use the
"Where Am I" functionality of Orca to obtain the accessible description for more
information.

Thank you for your work!
Comment 34 Mechtilde 2009-07-19 18:28:26 UTC
as I understand the lasst comment

verified -> closed