Issue 69989 - directory creation can fail during parallel builds
Summary: directory creation can fail during parallel builds
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: current
Hardware: All Windows, all
: P3 Trivial (vote)
Target Milestone: OOo 2.1
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-29 17:55 UTC by quetschke
Modified: 2007-01-09 10:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch for unitools.mk (824 bytes, patch)
2006-09-30 04:16 UTC, quetschke 		no flags Details | Diff
patch for solenv/inc (25.67 KB, patch)
2006-09-30 17:15 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-09-29 17:55:43 UTC 
I just got:

-------------
/cygdrive/d/w1/tin_ws/filter/source/config/fragments/filters
mkout -- version: 1.7
mkdir.pl ../../../../wntmsci10.pro/misc/filters/ui/fragments/filters/
guw.pl cfgex -p filter -i StarOffice_XML__Base__ui.xcu -o
../../../../wntmsci10.pro/misc/filters/ui/fragments/filters/StarOffice_XML__Base__ui.xcu
-m localize.sdf -l all
-------------
mkdir.pl ../../../../wntmsci10.pro/misc/filters/ui/fragments/filters/
guw.pl cfgex -p filter -i HTML__StarWriter__ui.xcu -o
../../../../wntmsci10.pro/misc/filters/ui/fragments/filters/HTML__StarWriter__ui.xcu
-m localize.sdf -l all
mkdir.pl ../../../../wntmsci10.pro/misc/filters/ui/fragments/filters/
Running processes: 2
/cygdrive/d/w1/tin_ws/filter/source/config/tools/utils
dmake: Executing shell macro: -+ls -1 $(JARDIR) | $(GREP) "^$i"
Can´t create directory filters at /cygdrive/d/w1/tin_ws/solenv/bin/mkdir.pl line 56.

Probably two reasons:
* One of two simultaneous calls fails but there is no '-' in front of the
  corresponding $(MKDIRHIER) call in tg_config.mk

* Why is W32-??sh using mkdir.pl? The perl script is a lot more susceptible
  to this race.

P.S.: All the "+" in front of $(MKDIR[HIER]) are unneeded, W32-4nt defines it's
own in unitools.mk.
Comment 1 quetschke 2006-09-30 04:16:42 UTC 
Created attachment 39462 [details]
patch for unitools.mk
Comment 2 quetschke 2006-09-30 04:18:41 UTC 
The previous patch fixed the problem for me (at least in the one test I did).

I'll also prepare a patch to add the missing '-' and remove the '+' in front of
$(MKDIR[HIER]).
Comment 3 quetschke 2006-09-30 17:15:33 UTC 
Created attachment 39472 [details]
patch for solenv/inc
Comment 4 quetschke 2006-10-04 20:31:02 UTC 
Committed to vq37.

Please verify that I didn't break W32-4nt. W32-bash works fine here.
Comment 5 hjs 2006-10-05 15:10:48 UTC 
looks good and builds fine with 4nt.
Comment 6 hjs 2007-01-09 10:34:34 UTC 
.