Issue 70027 - Filename and line missing if makefile error is on last line
Summary: Filename and line missing if makefile error is on last line
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-01 20:55 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-10-01 20:55:35 UTC 
Try the following example:

--- makefile.mk ---
SHELL*:=/bin/sh 
SHELLFLAGS*:=-ce

all : 
	+echo allA

all : 
	+echo allB

--- makefile.mk ---

You will get:

dmake:  Error: -- Multiply defined recipe for target all

Add another target at the end and the error message will be a lot more usefull:
dmake:  t_errorline.mk:  line 10:  Error: -- Multiply defined recipe for target all


Fix: In Parse() move the Closefile() behind the Bind_rules_to_targets().
Comment 1 quetschke 2006-10-16 21:44:35 UTC 
Already committed (with testcase) to dmake47.
Comment 2 quetschke 2006-10-16 21:45:14 UTC 
Please verify.
Comment 3 hjs 2007-01-17 11:48:54 UTC 
.
Comment 4 hjs 2007-01-23 14:33:16 UTC 
seen in MWS