Issue 70959 - getUTF32Character defined three times
Summary: getUTF32Character defined three times
Status: CLOSED FIXED
Alias: None
Product: ucb
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: Stephan Bergmann
QA Contact: issues@ucb
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-27 23:38 UTC by pavel
Modified: 2007-05-31 13:56 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2006-10-27 23:38:01 UTC 
We have

tools/inc/inetmime.hxx:inline sal_uInt32 INetMIME::getUTF32Character(const
sal_Unicode *& rBegin, ...

ucb/source/ucp/hierarchy/hierarchyuri.cxx:inline sal_uInt32
getUTF32Character(sal_Unicode const *& rBegin, ...

ucb/source/ucp/package/pkguri.cxx:inline sal_uInt32
getUTF32Character(sal_Unicode const *& rBegin, ...

Can we please get rid of two of them?

It is connected with #i70651#, but this time functions are in .cxx, no header ->
I can't use pragma. So I will temporary delete "inline".
Comment 1 Stephan Bergmann 2006-10-30 08:40:05 UTC 
@abi:  Please refactor code so that only one function definition is needed.
Comment 2 andreas.bille 2006-10-30 12:12:33 UTC 
accepted
Comment 3 pavel 2007-01-15 20:04:27 UTC 
abi: can you make it into 2.3?
Comment 4 pavel 2007-01-17 18:48:20 UTC 
This can wait for 2.3, I think.
Comment 5 andreas.bille 2007-04-04 13:48:35 UTC 
ABI->KSO: As discussed ...
Comment 6 kai.sommerfeld 2007-04-04 16:27:08 UTC 
.
Comment 7 kai.sommerfeld 2007-04-23 17:26:11 UTC 
Wrong component.
Comment 8 kai.sommerfeld 2007-04-23 17:42:35 UTC 
Fixed. Only one implementation left => tools/inc/inetmime.hxx
Comment 9 kai.sommerfeld 2007-04-24 07:46:26 UTC 
.
Comment 10 kai.sommerfeld 2007-05-03 14:21:59 UTC 
kso->sb: Please verify.
Comment 11 Stephan Bergmann 2007-05-03 14:58:34 UTC 
verified by code review
Comment 12 Stephan Bergmann 2007-05-31 13:56:59 UTC 
.