Issue 71111 - OOE680_m1: sfx2/source/doc/docinf.cxx build error
Summary: OOE680_m1: sfx2/source/doc/docinf.cxx build error
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC (x86_64) Linux, all
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: mikhail.voytenko
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-02 12:12 UTC by pavel
Modified: 2006-11-13 09:35 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2006-11-02 12:12:35 UTC 
Hi,

on GNU/Linux on x86_64, OOE680_m1:

/data/oo/BuildDir/ooo_OOE680_m1_src/sfx2/source/doc/docinf.cxx: In member
function 'BOOL SfxDocumentInfo::LoadFromBinaryFormat(SvStream&)':
/data/oo/BuildDir/ooo_OOE680_m1_src/sfx2/source/doc/docinf.cxx:1717: error: no
match for 'operator>>' in 'rStream >>
((SfxDocumentInfo*)this)->SfxDocumentInfo::nReloadSecs'
Comment 1 Stephan Bergmann 2006-11-02 13:08:01 UTC 
Appears to be a result of issue 54498, which introduced the change

tools/inc/solar.h:1.41
< typedef sal_uInt32            ULONG;  /* typedef unsigned long   ULONG; */
---
> typedef sal_uIntPtr           ULONG;  /* typedef unsigned long   ULONG; */

nReloadSecs is ULONG, SvStream has an operator >>(sal_uInt32 &), and until
solar.h:1.40 everything happened to work.  Probably best to change nReloadSecs
to sal_uInt32.
Comment 2 pavel 2006-11-02 13:21:58 UTC 
it helped, yes -> sfx2 compiles.
Comment 3 mikhail.voytenko 2006-11-03 07:43:11 UTC 
.
Comment 4 mikhail.voytenko 2006-11-03 07:49:26 UTC 
The suggested by SB workaround is commited.
But I would say that changing the size of the ULONG in this way is wrong,
because ULONG was defined to support the common Windows types, and Windows
documentation explicitly specifies ULONG as 32 bit.
Comment 5 kendy 2006-11-03 15:14:46 UTC 
mav: What exactly did you commit, please?
Comment 6 mikhail.voytenko 2006-11-03 16:02:59 UTC 
The commited files are
sfx2/inc/docinf.hxx
sfx2/source/doc/docinf.cxx
Comment 7 rt 2006-11-07 08:46:31 UTC 
This issue has been reported for OOE680 m1, the fix went into SRC680. Do we need
it on OOE680, too? Is there any risk in applying it to this release master (as
mav said something about 'wrong fix' ...)
Comment 8 pavel 2006-11-07 08:52:44 UTC 
rt: it should be applied to OOE as well.
The fix is safe.
Comment 9 mikhail.voytenko 2006-11-07 09:14:21 UTC 
The commited for this issue fix is completely OK.

When I wrote '...I would say that changing the size of the ULONG in this way is
wrong...', I have meant the new typedef for the ULONG type
typedef sal_uIntPtr           ULONG;
introduced by fix for issue 54498.
Comment 10 rt 2006-11-07 10:01:02 UTC 
OK, committed as masterfix to OOE680.
Comment 11 rt 2006-11-13 09:35:38 UTC 
Closing.