Issue 71777 - dmake 4.7 - tests broken for solaris
Summary: dmake 4.7 - tests broken for solaris
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All Unix, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-20 14:15 UTC by hjs
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
fix tests on solaris (2.27 KB, patch)
2006-11-20 14:19 UTC, hjs 		no flags Details | Diff
tests log: generated sh script no executable; .DIRCACHE still casesensitive (6.16 KB, text/plain)
2006-11-20 14:20 UTC, hjs 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hjs 2006-11-20 14:15:20 UTC 
attached a patch to fix some uname problems.

also case insensitive dircache and silent group receipts fail on solaris and linux
Comment 1 hjs 2006-11-20 14:16:12 UTC 
.
Comment 2 hjs 2006-11-20 14:19:04 UTC 
Created attachment 40768 [details]
fix tests on solaris
Comment 3 hjs 2006-11-20 14:20:44 UTC 
Created attachment 40769 [details]
tests log: generated sh script no executable; .DIRCACHE still casesensitive
Comment 4 quetschke 2006-11-20 17:41:38 UTC 
@ause: Please use this patch:

+++ dmake/unix/dcache.c 20 Nov 2006 17:39:41 -0000
@@ -142,6 +142,7 @@
            while((direntp=readdir(dirp)) != NULL) {
               TALLOC(ep,1,Entry);
               ep->name = DmStrDup(direntp->d_name); /* basename only */
+              printf("Caching:%s\n", ep->name);
               if( !STOBOOL(DcacheRespCase) )
                  strlwr(ep->name);
 


to check if test.target is added to the cache.
Comment 5 hjs 2006-11-20 20:16:33 UTC 
argl! i was too blind!
the path handed over to Set_dir is all lowercase while it isn't on the
filesystem (.../SRC680/...) -> no chdir

does this testcase make any sense at all for case sensitive filesystems??
Comment 6 quetschke 2006-11-20 20:40:41 UTC 
The joys of path normalization ;) Worked for me because everything was lowercase
here.

No, actually .DIRCACHERESPCASE=no doesn't make sense on case sensitive
filesystems. The current default is respects the case sensitivity of the FS, i.e.
.DIRCACHERESPCASE=no for Windows and Mac. So I think we should just do this
check for cygwin and `uname` on Mac (whatever that is).
Comment 7 quetschke 2006-11-21 01:34:54 UTC 
I changed the testcase to only test the directory cache for case 
insensitivity if the FS is also case insensitive.
Comment 8 quetschke 2006-11-21 01:35:43 UTC 
Please verify.
Comment 9 hjs 2006-11-21 11:52:52 UTC 
tests work now on solaris and linux
Comment 10 hjs 2007-01-23 14:45:47 UTC 
seen in MWS