Issue 72210 - dmake build with --enable-spawn ignores the '-' recipe switch
Summary: dmake build with --enable-spawn ignores the '-' recipe switch
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-02 16:27 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake/unix/runargv.c (1.39 KB, patch)
2006-12-02 16:46 UTC, quetschke 		no flags Details | Diff
Use this patch instead (1.39 KB, patch)
2006-12-02 17:01 UTC, quetschke 		no flags Details | Diff
Minimal patch (1.05 KB, patch)
2006-12-02 18:22 UTC, quetschke 		no flags Details | Diff
Grrr, missing detail. (1.31 KB, patch)
2006-12-02 19:09 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-12-02 16:27:48 UTC 
... for non-shell recipes.

I found this by code inspection but it's easy to test. The following makefile:

- - - -
SHELL*:=/bin/sh
SHELLFLAGS*:=-ce

all :
	-blabla
	@echo OK
- - - -

shows the difference:

$ ./dmakespawn.exe -r
blabla
Error: -- spawn failed: blabla: No such file or directory

quetschke@Turion /cygdrive/d/w1/cws_src680_dmake47
$ ./dmakefork.exe -r
blabla
Error: -- execvp failed: blabla: No such file or directory
OK
Comment 1 quetschke 2006-12-02 16:46:26 UTC 
Created attachment 41073 [details]
Patch for dmake/unix/runargv.c
Comment 2 quetschke 2006-12-02 16:48:40 UTC 
@ause: Easy fix, still OK for dmake47?
Comment 3 quetschke 2006-12-02 17:01:28 UTC 
Created attachment 41074 [details]
Use this patch instead
Comment 4 quetschke 2006-12-02 18:22:37 UTC 
Created attachment 41076 [details]
Minimal patch
Comment 5 quetschke 2006-12-02 18:27:13 UTC 
Committed to dmake47.
Comment 6 quetschke 2006-12-02 19:09:18 UTC 
Created attachment 41078 [details]
Grrr, missing detail.
Comment 7 quetschke 2006-12-02 19:13:36 UTC 
Committed previous patch and a testcase.

@ause: This patch only touches the spawn part of dmake so I fixed it in dmake47
even though it was already "Ready-for-QA".

Please verify.
Comment 8 hjs 2007-01-17 17:36:24 UTC 
.
Comment 9 hjs 2007-01-23 14:11:09 UTC 
seen in MWS