Issue 72646 - lowhanging fruits to speedup windows/cygwin packing
Summary: lowhanging fruits to speedup windows/cygwin packing
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: current
Hardware: All Windows, all
: P3 Trivial (vote)
Target Milestone: OOo 2.2
Assignee: hjs
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-16 15:02 UTC by hjs
Modified: 2007-01-23 15:13 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
less calls to cygpath (6.02 KB, patch)
2006-12-16 15:03 UTC, hjs 		no flags Details | Diff
same patch, a bit cleanup (5.40 KB, patch)
2006-12-16 18:33 UTC, hjs 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hjs 2006-12-16 15:02:39 UTC 
in msiglobal.pm there are lots of shell calls to "cygpath" which slow down some
steps of packing...
Comment 1 hjs 2006-12-16 15:03:42 UTC 
Created attachment 41466 [details]
less calls to cygpath
Comment 2 hjs 2006-12-16 18:33:17 UTC 
Created attachment 41467 [details]
same patch, a bit cleanup
Comment 3 hjs 2006-12-16 18:36:22 UTC 
hm, seems to cut down the overall time spent in instsetoo_native/util to 20%.
might require a second pair of eyes to make sure there isn'it anything lost.
Comment 4 ingo.schmidt-rosbiegal 2006-12-18 10:09:00 UTC 
IS -> HJS: Please feel free to commit this patch. I would propose to add
$installer::globals::cyg_temppath also into @installer::globals::removedirs,
that it will be removed at end of packaging process.
Comment 5 hjs 2006-12-18 13:19:15 UTC 
committed second patch
Comment 6 hjs 2006-12-18 13:35:21 UTC 
please verify
Comment 7 hjs 2007-01-23 15:13:56 UTC 
.