Issue 73688 - aquavcl01->use default system font instead of helvetica in aqua
Summary: aquavcl01->use default system font instead of helvetica in aqua
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: 680m196
Hardware: All Mac OS X, all
: P3 Trivial with 1 vote (vote)
Target Milestone: OOo 2.3
Assignee: hdu@apache.org
QA Contact: issues@porting
URL:
Keywords: aqua
Depends on:
Blocks: 74396
  Show dependency tree
 
Reported: 2007-01-20 21:56 UTC by eric.bachard
Modified: 2007-07-09 22:18 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
bad default fonts (maybe Times New Roman instead of helvetica) (317.62 KB, image/jpeg)
2007-01-20 23:03 UTC, eric.bachard 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description eric.bachard 2007-01-20 21:56:54 UTC 
This issue is one of 10 most important issues to fix before first public release of native ( Aqua , without 
X11) version of OpenOffice.org on Mac OS X

To be fixed :

In main menubar, Lucida Grande ( default system font) is used.

Everywhere else, helvetica is used

To do : make Lucida Grande used in native menus (all) , and other selected fonts if possible.
Comment 1 pavel 2007-01-20 22:26:11 UTC 
Can you please ilustrate this on screenshot?
Comment 2 eric.bachard 2007-01-20 23:03:15 UTC 
Created attachment 42340 [details]
bad default fonts (maybe Times New Roman instead of helvetica)
Comment 3 eric.bachard 2007-01-20 23:05:49 UTC 
ericb->pjanik

Screenshot is attached 

1) maybe I was confused between Times New Roman and helvetica , not sure

2) I ilmplemented UpdateSettings() and everything from macosxrc.txt can be use, but *not* fonts

Maybe ssa can answer ?  I know remember he forced something for fonts, because font attribute 
coudn't be found (was it locale issue ? )
Comment 4 eric.bachard 2007-01-20 23:08:19 UTC 
sorry for the typos : 

s/ilmplemented/implemented/
s/I know remember/I now remember/
Comment 5 eric.bachard 2007-01-22 11:41:00 UTC 
setting keyword
Comment 6 shaunmcdonald131 2007-02-10 10:34:19 UTC 
Adding to Meta Issue.
Comment 7 eric.bachard 2007-04-28 22:43:16 UTC 
After a discussion with ssa, it appears that the problem is in SetFont() , not working correctly
Comment 8 eric.bachard 2007-05-16 15:47:27 UTC 
ericb->hdu

IMHO, your changes fixed this issue. Can you confirm ?  

Thanks :)
Comment 9 eric.bachard 2007-05-19 08:26:24 UTC 
Reassigning issue to macport
Comment 10 hdu@apache.org 2007-05-25 08:18:15 UTC 
There were three reasons why the system default font wasn't used:
  1. the system default font wasn't known in OOo
  2. the methods to query details about a specific font were only dummy implemented
  3. so OOo didn't know enough about the font to let it pass the test Window::ImplCheckUIFont() test

  1. is solved by AquaSalFrame::UpdateSettings() asking the OSX Appearance Manager
  2. a better dummy implemtentation was provided
  3. => the font now passes the CheckUIFont test

From my point of view this problem can be considered as solved. Please verify.
Comment 11 hdu@apache.org 2007-06-14 12:12:47 UTC 
reassigned to dev
Comment 12 pavel 2007-06-24 11:00:41 UTC 
Verified.
Comment 13 pavel 2007-06-28 06:58:36 UTC 
Change target milestone to 2.3.
Comment 14 eric.bachard 2007-07-09 22:18:09 UTC 
Verified Ok in SRC680_m220
Comment 15 eric.bachard 2007-07-09 22:18:35 UTC 
Closing