Issue 73918 - Mark some internal dmake macros as precious
Summary: Mark some internal dmake macros as precious
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 77992
  Show dependency tree
 
Reported: 2007-01-26 18:18 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (5.25 KB, patch)
2007-01-27 00:04 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2007-01-26 18:18:14 UTC 
Dmake internally allows to treat macros as precious. They can only be overridden
if the force operator ! is used.

The internal macros PWD, MAKEDIR and TMD are currently overridable by the user
even though that doesn't make sense as they are redefined during the runtime.

Setting them can only confuse dmake. See issue 61212 as an example.

Ideally there should be a new macro property M_INTERNAL or so marking macros
that are never ever to be overridden by the user as currently you still can
force a new value on M_PRECOIUS macros but marking them as precious shall be
good enough for now.
Comment 1 quetschke 2007-01-27 00:04:19 UTC 
Created attachment 42499 [details]
Patch for dmake
Comment 2 quetschke 2007-01-27 00:54:19 UTC 
The patch contains also some clean ups and comment changes.

Committed.

I verified manually that PWD doesn't get imported anymore.

@ause: Please verify.

P.S.: The
PWD:=$(shell +echo %_cwd)
in wnt/macros.mk should now be unneeded.
Comment 3 quetschke 2007-01-27 00:55:25 UTC 
Forgot to say: Committed to dmake48.
Comment 4 hjs 2007-05-31 14:53:59 UTC 
.
Comment 5 hjs 2007-07-13 13:55:28 UTC 
dmake 4.8 is on the MWS now