Issue 74877 - Extension Manager: Interaction handler should only be called if necessary
Summary: Extension Manager: Interaction handler should only be called if necessary
Status: ACCEPTED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 680m202
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-26 13:39 UTC by joachim.lingner
Modified: 2013-08-07 15:31 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description joachim.lingner 2007-02-26 13:39:00 UTC 
... this refers to the VersionException and InstallException. See

desktop/source/deployment/gui/dp_gui_cmdenv.cxx 
desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx

Also make sure that if not handled an DeploymentException is thrown. This should
enable that XPackageManager::addPackage can be called without
XCommandEnvironment implementation.

If this is fixed then the XCommandEnvironment implementation which is used for
the smoketest can also be removed. See 
javaunohelper/com/sun/star/comp/...
Comment 1 joachim.lingner 2007-02-26 13:43:14 UTC 
Eventually we need to modify the implementation XPackage::checkPrerequisites so
that it throws an DeploymentException rather then returning false.
Comment 2 joachim.lingner 2007-02-26 13:44:09 UTC 
.
Comment 3 joachim.lingner 2007-02-27 12:31:35 UTC 
The InstallException is currently always thrown when an extension is about to be
installed. Only the XInteractionHandler (the XCommandEnvironment which is passed
as argument in addPackage) knows if it needs to notify the user. This is for
example the case when the user installs an extension with a double-click. Then
the XCommandEnvironment is created with a particular flag, indicating to ask the
user. This information should be removed from the XCommandEnvironment and be
part of the XPackageMananger::addPackage.
See also i74908
Comment 4 ronyf 2007-07-07 14:45:09 UTC 
Supplying null for the XCommandEnvironment has already worked in 2.1 (and 2.0
for that matter, if I recall correctly)! 

It seems that issue 74908
<http://qa.openoffice.org/issues/show_bug.cgi?id=74908> is the same?
Comment 5 joachim.lingner 2007-07-23 13:09:21 UTC 
target 2.4
Comment 6 joachim.lingner 2007-10-16 08:49:23 UTC 
Retargeted to 3.0.
See also issue 74908
Comment 7 joachim.lingner 2008-05-21 09:24:14 UTC 
Retargeted to 3.1
Comment 8 joachim.lingner 2008-12-09 15:01:54 UTC 
.
Comment 9 joachim.lingner 2009-09-03 10:02:55 UTC 
Target 3.3
Comment 10 joachim.lingner 2010-02-05 12:59:23 UTC 
Retargeting to 3.x.
Comment 11 joachim.lingner 2010-02-05 13:01:35 UTC 
.