Apache OpenOffice (AOO) Bugzilla – Issue 76431
MakeReadOnlyDocumentWritable doesnt work if refresh is very low.
Last modified: 2009-08-20 08:15:59 UTC
1. Create new file, 2. In File-Properties, goto tab-page "Internet" 3. Set the "Refresh"-value to 1 second. 4. Press ok to close the dialogue. 5. Save and close the document. 6. Make it read only. 7. Open the file. 8. Now, if you wish to work with the document, by making it "editable" (or open a copy of the document), - you'll have quite a problem pressing the "Edit read-only"-button. And if you do this in an automatic test - it will fail. Probably not usual to have a refresh set on one second, but the reason I'm writing this issue, is that I accidentally had used a document with 1-sec-refresh - as a template for several other test-documents. Which, when I tried accessing the files with a account that didn't have write-rights, screwed up quite a lot. Bug: you should be able to click the "Edit read-only"-button in any case.
*** Issue 76432 has been marked as a duplicate of this issue. ***
Well, what do you suggest what should be done here? Garbage in, garbage out! The only "fix" would be do ignore refresh times below a certain value. But why then have this feature at all? 1 second is just not enough to do the necessary processing, sorry. The "Edit document" button is executed asynchronously. So if you are fast you might be able to press the button but before the function can be executed the document is gone. This very strange situation does not justify the necessary effort to implement the special case treatments (sometimes called "hacks") to support it.
mba: According to user-experience, the possibility to set the refresh-timing to 1 second is unneeded. A more reasonable "lowest value" is one minute.
So is this a request to change the minimum value in the dialog? Or a request to ignore all smaller values on opening the document? Or a request to ignore auto reload at all (as we are no browser)? As this is of doubtful importance I changed the target accordingly. In case somebody can come up with a spec we might change the target back to the next possible release.
It is a request to change the minimum value to 1 minute.
Change it in the dialog or in the code that evaluates reload times when a document is loaded? Changing it in the dialog will conflict with the usage as an HTML editor (and IMHO this is the only reason why we have this stupid feature at all) as HTML pages indeed can have shorter reload times (even 0 seconds are used to have a "poor man's redirect"). Moreover reload data is part of the ODF file format and ODF does not limit the data to any value. Even if we changed it in our dialog it's still possible to create such documents with other ODF capable applications or as an HTML file. So a limit in the dialog is not a real option. Ignoring reload times less than 1 minute on document load makes it doubtful why we consider reload times at all as the 1 minute limit looks pretty randomly chosen and makes the whole feature confusing for the user. So perhaps then we better don't do any relaod at all. OTOH ignoring reload times completely will make it an "HTML file only" feature. Then the question arises why we have it at all. The answer probably is "because ODF specifies it". (CC'ing MIB for this reason) So there some questions to discuss and answer and that might happen if somebody will have time for it.
There are other scenarios when a user might use this feature. For instance when a group of people have access to the same file, which is administrated by one person. The whole group should not have write-access to the file, but they still need to have the latest version of the file. And if the person administrating the file sets the refresh too low, the other people might not have such a good time. Unfortunately is this scenario also most likely to happen where we the least wish for it to happen: in some bigger company. But as you mention - it's a tricky thing to solve in a good way.
Good point. So there is at least some value for the feature even outside of HTML. Unfortunately this leaves me even more confused. What I also dislike is binding this feature to the file being opened read-only. This is something that the user doesn't have under control - exactly that was your problem as it seems. Perhaps auto load should be done only when the user deliberately chose to open the file read-only or if the meta data contains the information that the file must be opened read-only be default. But auto load shouldn't be done just because the file was opened read-only due to insufficient user rights.
Even if this issue issue is somewhat annoying i do not think we're going to fix it. There have been attempts to circumvent the problem within the autotest scripts with limited but - for now - sufficient success. So i'm closing the issue.
.