Issue 76720 - Don't call deprecated functions that do nothing
Summary: Don't call deprecated functions that do nothing
Status: ACCEPTED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All Windows XP
: P3 Trivial (vote)
Target Milestone: AOO Later
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-26 14:49 UTC by tml
Modified: 2013-07-30 02:36 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description tml 2007-04-26 14:49:56 UTC 
The bodies of the enableQuitTimer() and disableQuitTimer() functions in
framework/source/classes/framecontainer.cxx are completely commented out and
said to be deprecated. The calls to these functions and related comments should
then be removed from framework/source/services/desktop.cxx, to avoid misleading
people reading the code. I don't know if the FrameContainer API is considered
stable, or whether the functions could be removed altogether from the class.

There is also stuff in framecontainer.cxx that has been commented out
completely, not just the body. What is the point in having that still in the
source code, just for historical interest? Isn't that what version control is for?
Comment 1 Mathias_Bauer 2007-04-26 16:26:51 UTC 
Andreas, I assume that this is a residue from earlier versions where closing the
last frame automatically has shut down OOo. Am I right? So tml is right, we
should clean up the code.
Comment 2 andreas.schluens 2007-05-08 07:32:34 UTC 
AS: accepted. These code isn't used any longer and can be removed.
Comment 3 Rob Weir 2013-07-30 02:36:13 UTC 
Reset assignee on issues not touched by assignee in more than 1000 days.