Issue 76764 - unused code in binfilter/bf_sfx2
Summary: unused code in binfilter/bf_sfx2
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: hjs
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-27 15:44 UTC by hjs
Modified: 2007-08-30 15:53 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
stripped list of symbols pointing to probably dead code (7.74 KB, text/plain)
2007-04-27 15:49 UTC, hjs 		no flags Details
complete list, including symbols from outside binfilter (27.75 KB, text/plain)
2007-04-27 15:50 UTC, hjs 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hjs 2007-04-27 15:44:56 UTC 
due to an error caused by changing the way bf_sfx code is linked to bf_svx we
found that previously a couple of symbols from bf_sfx2 where discarded from the
linked archive because they were neither referenced nor exported.
now that the objects from bf_sfx2 are linked, these symbols are present in
bf_svx shared library.
althought this is bad as it increases the size of bf_svx a bit, it points to
dead code in bf_sfx2 which probably can be removed.
Comment 1 hjs 2007-04-27 15:49:24 UTC 
Created attachment 44737 [details]
stripped list of symbols pointing to probably dead code
Comment 2 hjs 2007-04-27 15:50:55 UTC 
Created attachment 44738 [details]
complete list, including symbols from outside binfilter
Comment 3 Mathias_Bauer 2007-04-27 15:58:34 UTC 
I will remove the corresponding source files.
Comment 4 Mathias_Bauer 2007-04-28 14:30:08 UTC 
Strange, some of the symbols have been still in use. I could remove them except
the SfxPrinter and SfxFont stuff.
Comment 5 hjs 2007-04-30 10:57:36 UTC 
which platfrom still requires these symbols?
Comment 6 Mathias_Bauer 2007-04-30 11:01:28 UTC 
All platforms.

BTW: did you have a look at issue 76195 ? :-)
Comment 7 hjs 2007-04-30 17:09:57 UTC 
argl! solution is: these makefiles also link against static sfx2 archive :(

./bf_sc/util/makefile.mk:                       $(BFSFXLIB)
./bf_sch/util/makefile.mk:                      $(BFSFXLIB)
./bf_sd/util/makefile.mk:                       $(BFSFXLIB)
./bf_starmath/util/makefile.mk:                 $(BFSFXLIB)
./bf_sw/util/makefile.mk:                                               $(BFSFXLIB)
./filter/source/bf_offwrp/makefile.mk:                  $(BFSFXLIB)
Comment 8 Mathias_Bauer 2007-06-01 16:22:38 UTC 
ause, please verify if now the util/makefile.mk in binfilter are correct (even
after three resyncs)
Comment 9 hjs 2007-06-04 18:17:45 UTC 
ok, not a */util/makefile.mk, but filter/source/bf_offwrp/makefile.mk still uses
BFSFXLIB. maybe it's also a good idea to remove this variable in solenv/inc/libs.mk
Comment 10 Mathias_Bauer 2007-07-02 22:46:26 UTC 
ause: can you verify the correctness of the applied changes in the util
makefiles of binfilter?
Comment 11 hjs 2007-07-04 14:31:20 UTC 
.
Comment 12 hjs 2007-08-30 15:53:18 UTC 
.