Issue 78383 - Can we actually print the XError on catching it
Summary: Can we actually print the XError on catching it
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All Unix, all
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: hdu@apache.org
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-13 13:34 UTC by caolanm
Modified: 2007-07-10 14:00 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
just print the XError if we catch one (953 bytes, text/plain)
2007-06-13 13:35 UTC, caolanm 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2007-06-13 13:34:28 UTC 
I see that we have the PrintXError inside a ifdef for DEBUG and another use of
it after the signal returns, but what I see is that in a pro version that the
signal handler calls _exit so we never return to vcl for it to get to call the
2nd PrintXError, how about just the following trivial patch to always print the
XError.
Comment 1 caolanm 2007-06-13 13:35:11 UTC 
Created attachment 45874 [details]
just print the XError if we catch one
Comment 2 philipp.lohmann 2007-06-13 20:54:24 UTC 
Yes, this is due to old demands of th that we shouldn't print anything to the
command line; if we want to notify the user about an error condition, then we
should pop up a box. While this may be the a nice idea, i think we can abandon
this old "requirement" altogether and do what you suggest. However we should
move the PrintXError below the check for the VCL display then (the display thing
can actually happen with clipboard and DnD.
Comment 3 caolanm 2007-06-13 21:06:21 UTC 
It's the default for gnome applications to spit out the XError if they encounter
one, so we can call doing the same as following the de-facto desktop standard
here :-)
Comment 4 philipp.lohmann 2007-06-18 15:42:26 UTC 
fixed in CWS vcl79
Comment 5 philipp.lohmann 2007-06-19 15:16:06 UTC 
please verify in CWS vcl79
Comment 6 hdu@apache.org 2007-06-19 15:36:07 UTC 
verified in CWS vcl79
Comment 7 hdu@apache.org 2007-07-10 14:00:06 UTC 
got into SRC680_m219 => closing