Issue 79625 - Suppress "dmake: Executing shell macro: ..." output
Summary: Suppress "dmake: Executing shell macro: ..." output
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: kay.ramme
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-15 05:57 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for solenv/inc (30.86 KB, patch)
2007-07-15 06:45 UTC, quetschke 		no flags Details | Diff
New patch (29.66 KB, patch)
2007-07-15 07:07 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2007-07-15 05:57:33 UTC 
The output
dmake: Executing shell macro: ...
of dmake's shell macro can be suppressed by prepending @ like in any other recipe.

Let's do this to suppress this generally unneeded output.

I'll check the $(shell ..) commands in solenv/inc and add the @'s.
Comment 1 quetschke 2007-07-15 06:45:05 UTC 
Created attachment 46790 [details]
Patch for solenv/inc
Comment 2 quetschke 2007-07-15 07:03:13 UTC 
@ause: The previous patch should help, not tested yet, but I found two strange
occurences of @@ that were used in a $(shell ..) command.

In solenv/inc/target.mk:
LOCALJARS:=$(foreach,i,$(shell @@-cd $(JARDIR) && ls -1 $(JARFILES) ) $(JARDIR)$/$i)

and in solenv/inc/tg_dep.mk:
	@@-echo $(foreach,i,$(DEPFILES) $(shell @@$(4nt_force_shell)-del $i))

...

Ah! The use of @@ in shell escapes suppresses the stderr output, together with
the '-' this is silencing the shell escape.

Sorry, the previous patch is wrong, I replaced the @@ in those places with @,
but that was wrong.
Comment 3 quetschke 2007-07-15 07:07:36 UTC 
Created attachment 46791 [details]
New patch
Comment 4 quetschke 2007-07-18 07:45:50 UTC 
@ause: The previous patch reduces the 'dmake: Executing shell macro: ...'
lines from 19083 to 72. (on m221, see last tinderbox build)

Do you have an auseXX cws where this can go? Or shall I create a new cws for this?
Comment 5 hjs 2007-07-18 09:33:41 UTC 
ause084? planned as post 2.3 cws
Comment 6 hjs 2007-07-18 16:09:56 UTC 
see also #i79760# which souns similar :). i don't close it as duplicate as
haven't had a look at the attached patch yet
Comment 7 quetschke 2007-07-18 17:18:21 UTC 
@ause: Well, issue 79760 handles the remaining 72 cases, it would be a shame to
close that issue.

How about you apply the solenv patch to ause084 (minimizes merging problems) and
I create a cws for the remaining 26 modules?
Comment 8 hjs 2007-07-23 16:34:18 UTC 
@vq: kr volunteered to do a "silencer" cws. there is also one more issue dealing
with deliver/build (#i79798#)
Comment 9 quetschke 2007-07-26 19:45:35 UTC 
Fine, handing over the issue.

@kr: You can make me QA'rep or ask me to verify this issue. (I see ause already
worked on the deliver/build issue).
Comment 10 hjs 2007-11-02 12:48:57 UTC 
isn't this issue done with upcomming integration of #i79760#?
Comment 11 kay.ramme 2008-03-07 15:52:32 UTC 
Going to close this, as this is double to i79760 and has been fixed ...
Comment 12 kay.ramme 2008-03-07 15:54:48 UTC 
.