Issue 80012 - dmake core dumps while deleting intermediate targets in parallel builds
Summary: dmake core dumps while deleting intermediate targets in parallel builds
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: OOo 2.2.1
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-25 05:24 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (653 bytes, patch)
2007-09-24 18:33 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2007-07-25 05:24:56 UTC 
The following makefile makes dmake core dump for parallel builds with -P2.

- - - -
SHELL*:=/bin/sh
SHELLFLAGS*:=-ce

.REMOVE :; @-+echo rm -rf $<

%.aaa : %.bbb
	@echo building $@
	@echo finished $@


%.bbb : %.ccc
	@echo building $@
	@sleep 2
	@echo finished $@

%.ccc :
	@echo building $@
	@echo finished $@

all : aaa.aaa
	+echo Done
- - - -

$ ./dmake/dmake.exe -P2 -rf makefile.mk 
building aaa.ccc
finished aaa.ccc
building aaa.bbb
finished aaa.bbb
rm -rf aaa.ccc
Aborted (core dumped)

(Not a new problem, happens also with older dmakes)
Comment 1 quetschke 2007-09-24 18:32:56 UTC 
The debug patch from issue 81821
http://www.openoffice.org/nonav/issues/showattachment.cgi/48421/iz81821_dbg_2.diff
made it rather easy to locate the bug.

Thou shalt not use static variables lightly!

The following patch fixes this problem for me.

IMHO this should still go into dmake411.
Comment 2 quetschke 2007-09-24 18:33:48 UTC 
Created attachment 48458 [details]
Patch for dmake
Comment 3 quetschke 2007-09-24 18:52:57 UTC 
Patch committed.
Comment 4 quetschke 2007-09-24 18:54:10 UTC 
I hope this really was the last issue for dmake411.

Maybe I commit a testcase later today.

Please verify.
Comment 5 hjs 2007-09-25 10:48:55 UTC 
helps a lot. now my cws depends on dmake411...
Comment 6 hjs 2007-12-21 13:38:38 UTC 
dmake 4.11 is in use now