Issue 80528 - Reduce complexity: Remove unnecessary display options
Summary: Reduce complexity: Remove unnecessary display options
Alias: None
Product: Draw
Classification: Application
Component: ui (show other issues)
Version: 680m225
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: christian.guenther
QA Contact: issues@graphics
Depends on:
Reported: 2007-08-09 14:29 UTC by Armin Le Grand
Modified: 2008-07-17 17:21 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

The Spec (now with pictures) (287.89 KB, text/plain)
2007-11-08 13:12 UTC, Armin Le Grand
no flags Details
Test case specification (6.66 KB, text/html)
2007-11-22 08:51 UTC, christian.guenther
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Armin Le Grand 2007-08-09 14:29:47 UTC
AW: According to the spec with the same tame this is the task to follow the
Comment 1 Armin Le Grand 2007-08-14 17:10:17 UTC
AW: Started with rough removal, building for tet purposes...
Comment 2 Armin Le Grand 2007-08-15 15:24:04 UTC
AW: First removals done for svx and sd, sc to go...
Comment 3 Armin Le Grand 2007-09-12 10:42:01 UTC
AW: svx, sd and sc were already cleared, but in sw, i found usages of show/hide
object categories. Together with sc's old excel import, i conclude that i need
to keep the show/hide functionality and remove the draft states.
Had to start over from svx, removing onlx the draft state will mbe more complex
than removing that whole show/draft/hide feature set.

Also: hanged OLEObjCache::UnloadObj since it only worked/did something when OLE
is in draft mode in all views. What is intended is more some 'is visible in any
view'-evaluation. Since this is possible now with the VOCs, i implemented it there.

Continuing with sd...
Comment 4 Armin Le Grand 2007-09-12 17:36:59 UTC
AW: svx, sd, sc and sw newly handled. Need to build the rest of the stuff to get
an install set (better due to the ressource changes) for testing...
Comment 5 Armin Le Grand 2007-09-13 11:28:35 UTC
AW: Removed part from optionsbar.xml for draw and impress (for HelpIDs):

 <toolbar:toolbaritem xlink:href=".uno:GraphicDraft"
toolbar:helpid="helpid:27146"  toolbar:style="auto" />
 <toolbar:toolbaritem xlink:href=".uno:FillDraft" toolbar:helpid="helpid:27147"
 toolbar:style="auto" />
 <toolbar:toolbaritem xlink:href=".uno:TextDraft" toolbar:helpid="helpid:27148"
 toolbar:style="auto" />
 <toolbar:toolbaritem xlink:href=".uno:LineDraft" toolbar:helpid="helpid:27149"
 toolbar:style="auto" />
Comment 6 Armin Le Grand 2007-09-13 16:17:33 UTC
AW: Install set works now, the toolbar entries for draw/impress ar removed.
Commenting and removing the #i80528#-tags...
Comment 7 Armin Le Grand 2007-09-13 16:42:59 UTC
AW: Need to check SdrObject::TakeContour(); there the draft modes were used to
paint graphics and text as polygons to the recorded metafile. This may need to
be replaced.
Comment 8 Armin Le Grand 2007-09-13 16:46:10 UTC
AW: Test-building with changes...
Comment 9 Armin Le Grand 2007-09-14 10:02:35 UTC
AW: As if i smelled it: TakeContour immediately crashed with the changes since
the paint to metafile of the clone also has the text and also uses TakeContour
for setting up the DrawOutliner -> recursive loop, stack overflow. ARGH!
I will need to add some temporary PaintMode to react on contour paint in
DoPaintObject for text and graphics. This will be a temporary solution until we
get the primitives. There, i would simply implement a ContourRenderer whcih
would process a fixed sequence of primitives and create polygons...
Comment 10 Armin Le Grand 2007-09-14 11:23:47 UTC
AW: Okay, new paintmode is SDRPAINTMODE_CONTOUR and i added support in
SdrGrafObj::DoPaintObject and SdrTextObj::DoPaintObject. Contour for graphics
did not work anyways, but works now.
AW: Checking in changes...
Comment 11 Armin Le Grand 2007-09-14 12:13:34 UTC
AW: Initializing builds on, and wntsci10...
Comment 12 Armin Le Grand 2007-09-14 14:14:26 UTC
AW: Builds progress, making experiments with debug version, checking contour
stuff in SW with SW's graphic objects and DrawingLayer's...
Comment 13 Armin Le Grand 2007-09-14 17:40:52 UTC
AW: During tests i stumbled over SC save_old -> load_new and vice versa with
changed show/hide/replacement settings. I debugged and looked for the error but
could not find import/export conde. Calling NN (amd doing some simple tests with
only one office) showed that these flags are not saved at all, thus there is no
All in all it works pretty well. Hopefully the builds will be ready, soon.
AW: I did some changes in SC to make ScVObjMode usage more safe. First version
was using %2 when assigning an integer to the type, new versions are more type
safe by using if(x > VOBJ_MODE_HIDE) x = VOBJ_MODE_SHOW before assignment.
Checking in...
Comment 14 Armin Le Grand 2007-09-14 17:51:30 UTC
AW: Builds look good (except windows, of course ;-). Updated SC, restarted builds...
Comment 15 Armin Le Grand 2007-09-19 14:26:08 UTC
AW->CGU: The following needs to be done for testing:

- auomatic tests of Draw/Impres and Calc
- Options toolbar in Draw and in Impress has 4 buttons less which were for draft
display modes: 'Picture Placeholders', 'Contour mode', 'Text Placeholders' and
'Line Contour Only'.
- Tools/Options/StarOfficeDraw/View and Tools/Options/StarOfficeImpress/View
misses the CheckBox group 'Alternative Display' which contained 'Image
Placeholders', 'Contour Mode', 'Text Placeholders' and 'Line contour only'
- Tools/Options/StarOfficeCalc/View the Group 'Objects' with the three DropDown
boxes misses the 'Placeholder' entry, only 'Show' and 'Hide' remain.
- Draw/Impress files created with the regular Office and any of the draft mode
options switched on (draft active) and loaded in this CWS-Version will have all
objects normally displayed again (no draft mode, options off).
- Draw/Impress files created with CWS-Version andl oaded in regular Office will
have all objects displayed without draft (options off).
- help content changed by UFI (see 2nd task),, and wntmsci10 install sets are ready.
Feel free to ask if You have questions. 
Comment 16 Armin Le Grand 2007-09-19 14:31:19 UTC
AW->CGU: Please verify as described.
Comment 17 christian.guenther 2007-10-31 15:13:34 UTC
I reopen the issue.
Comment 18 christian.guenther 2007-10-31 15:17:24 UTC
Back to you.
There is a empty area where the old entries have been.
The persist entries should shift upwards.
Comment 19 Armin Le Grand 2007-11-07 16:51:09 UTC
AW: Resync to m235 done, wntmsci10, and built.
AW: Changed ressource to move the remaining options in
tools/options/DrawImpress/View to the top. Built, but test installation does not
come up.
AW: Need to completely built version. I will see if that one will
start then. Else, i have to hunt problems after resync :-(
Comment 20 Armin Le Grand 2007-11-08 10:43:24 UTC
AW: wntmsci10 and are both working now (after rebuild). Changed
ressource (tpoption.src in sd) to move remaining options to the top in
tools/options/drawImpress/View. Checked in. Building installsets...
Comment 21 Armin Le Grand 2007-11-08 13:12:20 UTC
Created attachment 49524 [details]
The Spec (now with pictures)
Comment 22 Armin Le Grand 2007-11-08 13:13:56 UTC
AW: Install sets ready (,, wntmsci10,
Updated Spec attached (on this task).
Comment 23 Armin Le Grand 2007-11-08 13:14:29 UTC
AW->CGU: Please verify.
Comment 24 christian.guenther 2007-11-13 14:30:34 UTC
Verified in cws aw053
Comment 25 christian.guenther 2007-11-22 08:51:59 UTC
Created attachment 49806 [details]
Test case specification
Comment 26 christian.guenther 2008-07-17 17:21:13 UTC
CGU: Integrated in dev300m25 and beb300m3