Issue 80598 - dmake loops on target with .IGNORE and broken recipe
Summary: dmake loops on target with .IGNORE and broken recipe
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-11 00:13 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (3.73 KB, patch)
2007-08-11 21:19 UTC, quetschke 		no flags Details | Diff
Patch for dmake (2.17 KB, patch)
2007-10-06 05:57 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2007-08-11 00:13:44 UTC 
The following makefile loops:

SHELL*:=/bin/sh
SHELLFLAGS*:=-ce

all .IGNORE : 
	ttttouch all
Comment 1 quetschke 2007-08-11 01:32:56 UTC 
Happens only with a spawn using dmake, i.e. configured with --enable-spawn .
Comment 2 quetschke 2007-08-11 21:19:40 UTC 
Created attachment 47496 [details]
Patch for dmake
Comment 3 quetschke 2007-08-11 22:24:21 UTC 
Committed (plus testcase) to dmake411.
Comment 4 quetschke 2007-08-11 22:24:50 UTC 
Please verify
Comment 5 hjs 2007-10-05 17:29:02 UTC 
with dmake 4.9 i get

dmake:  Error: -- ttttouch: No such file or directory

which is a usefull hint. 
with dmake 4.11 this message is gone.  this of cause consistent with e.g.

.INCLUDE .IGNORE : no_such_file.mk

on the othere hand this could make it quite hard to find typos. note that this
also affects

all:
    -ttttouch all
Comment 6 quetschke 2007-10-06 05:56:39 UTC 
The error message is hidden behind a (any) verbose flag, try -vw, but you are
right, there is a difference between a recipe command failing with an error
and an invalid command. I also found that the native W32 version just fails
if spawnvpe fails to execute it.

The following (still untested) patch should solve both problems.
Comment 7 quetschke 2007-10-06 05:57:35 UTC 
Created attachment 48719 [details]
Patch for dmake
Comment 8 quetschke 2007-10-06 15:34:59 UTC 
Tested with native W32 dmake and cygwin dmake.

Committed patch and changed the testcase.

Please verify.
Comment 9 hjs 2007-10-10 15:46:40 UTC 
.
Comment 10 hjs 2007-12-21 13:37:41 UTC 
dmake 4.11 is in use now