Issue 81318 - The extension is not automatically removed by export dialog.
Summary: The extension is not automatically removed by export dialog.
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 680m225
Hardware: All Windows, all
: P3 Trivial with 2 votes (vote)
Target Milestone: OOo 2.3
Assignee: thorsten.martens
QA Contact: issues@framework
URL:
Keywords: oooqa
: 81051 (view as issue list)
Depends on:
Blocks:
 
Reported: 2007-09-06 11:20 UTC by mikhail.voytenko
Modified: 2007-09-13 06:44 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description mikhail.voytenko 2007-09-06 11:20:40 UTC
To reproduce the problem the office should be correctly installed on windows
with system integration ( no development installation )
- load a document ( for example test.ods )
- do export to pdf ( not important in which way )
- the export dialog suggests the document name "test.ods"

The problem is dangerous in case the system dialog is used. Because of issue
78556 the .pdf extension will not be added automatically in this case ( .ods
extension is known by the system ), thus there is a big possibility to export to
the original document and to get information lost.

This is a regression that was introduce by the fix for issue 68219.
Comment 1 cno 2007-09-06 15:01:16 UTC
BTW: looks the same for me as issue #72209
Comment 2 mikhail.voytenko 2007-09-06 16:15:41 UTC
No, originally the issue 72209 was submitted regarding the case when the
"Automatic file name extension" is not checked. So it describes different
problem. Only the last comment describes the behavior related to this bug.

The problem described here is reproducible starting from SRC680/m224, in m223 it
is not reproducible. This problem is about suggested file name, that is provided
in the dialog in default case  ( when user does not deselect any checkbox ). And
this is why it is so dangerous, it affects users who use the default settings.
Comment 3 philipp.lohmann 2007-09-06 17:58:46 UTC
excuse me, but could you explain to me how adding a new control to the IDL and
activating it could possibly adversely affect other implementations (like the
windows file picker) ? I do not remotely understand how this can be related to
issue 68219
Comment 4 andreschnabel 2007-09-06 18:16:58 UTC
andreschnabel->pl: 
see discussion at Issue 72209 - Windows File save dialog has some strange (but
according to hro - default) behavior: even if the option "automatic file name
extension" is checked, it does *not* return afilename with poper extension, if
the file name already contains an extension that is known to the windows system.

As .odt is registered, Windows File Picker will keep this instead off adding (or
replacing it by) .pdf.


 
Comment 5 mikhail.voytenko 2007-09-06 18:28:46 UTC
Actually the fix for the issue 68219 has only triggered the problem. It has
added and enabled a new control, that has triggered adding of an enable-command
in the internal queue of the filepicker.

The real problem was that the command queue in the filepicker implementation.
Sometimes it did not allow to do correct requests in case enable-commands were
in the queue.

The fix is ready and will be integrated in one of cws's as soon as possible.
Comment 6 philipp.lohmann 2007-09-06 18:31:55 UTC
that makes things clearer to me, thank you.
Comment 7 mikhail.voytenko 2007-09-07 10:25:01 UTC
The fix is integrated into mav24 cws.
Comment 8 mikhail.voytenko 2007-09-07 11:40:39 UTC
MAV->TM: Please verify the issue.
Comment 9 mikhail.voytenko 2007-09-07 12:46:04 UTC
*** Issue 81051 has been marked as a duplicate of this issue. ***
Comment 10 settantta 2007-09-09 10:45:59 UTC
IMO, 2.3.0 must not be released with this issue unfixed, for the reasons
relating to potential data loss given by the reporter.

I believe this to be a showstopper, and so I ma re-opening it. IMO it should get
a minimum P2 rating.
Comment 11 cno 2007-09-09 11:12:20 UTC
@settantta
Your opinion is clear, but IMO you break the logic sequence by reopening while
the issue is set to fixed and asked to be verified.
Comment 12 smolejv 2007-09-09 14:41:58 UTC
*** Issue 72209 has been marked as a duplicate of this issue. ***
Comment 13 cno 2007-09-09 15:29:50 UTC
@smolejv :
Reading your comments on Sun Dec 3 21:13:10 +0000 2006, one could possibly
understand that issue 72209 only occured when 'Automatic file extension' was not
checked. (As mav pointed out).
@*:
- So I'm not sure if fixing this 81318 will automagically fix 72209.
- Futhermore a question: does anyone know about an issue, to repair the
behaviour that OOo overwrites a file that is opened at the same time (which is
what happens when you export <name> to pdf as <name.odt> - and maybe also in
other situations) ?

Thanks,
Cor
Comment 14 Martin Hollmichel 2007-09-10 16:16:42 UTC
set target.
Comment 15 cno 2007-09-10 16:18:55 UTC
Guess what. In a hurry, just two minutes ago, file export to PDF for customer,
Enter :-)
Oops! 
Hapily thought about it just in time, to save the doc on screen again as odt.

So: great and brave decision, thanks!
Comment 16 thorsten.martens 2007-09-11 08:24:53 UTC
Checked and verified in cws mav24 -> OK !
Comment 17 merschmann 2007-09-12 22:03:28 UTC
Found fixed in 2.3.0-RC3 on WinXP-Pro
Comment 18 andreschnabel 2007-09-13 06:44:52 UTC
ok in OOO 2.3rc3