Issue 81383 - Internal changes of ASC and JIS function
Summary: Internal changes of ASC and JIS function
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: 680m223
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on: 81366
Blocks:
  Show dependency tree
 
Reported: 2007-09-08 10:11 UTC by bluedwarf
Modified: 2013-08-07 15:14 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The proposed patch based on SRC680_m223 (12.31 KB, patch)
2007-09-08 10:12 UTC, bluedwarf 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bluedwarf 2007-09-08 10:11:16 UTC 
Following my patches of new transliteration moduels, attached on i81366, I
simplified the implementation of ASC and JIS function.

With the proposed patch, we don't need a big extra mappnig table for JIS and ASC
function because the new transliteration modules share much parts of existing
mapping table between halfwidth characters and fullwidth characters.

Please consider applying the proposed patch, which will be attached soon here.
Comment 1 bluedwarf 2007-09-08 10:12:53 UTC 
Created attachment 48060 [details]
The proposed patch based on SRC680_m223
Comment 2 bluedwarf 2007-09-08 10:23:58 UTC 
See
http://wiki.services.openoffice.org/wiki/Calc/Features/JIS_and_ASC_functions
to confirm that this modification keeps upward compatibility with version 2.3.
Comment 3 ooo 2007-10-09 12:38:35 UTC 
I was on vacation the last weeks, hence the long silence.

Accepting patch based on changes that will be introduced with issue 81366.
Aligning target with issue 81366, "not determined" yet.
Comment 4 bluedwarf 2008-08-21 11:38:13 UTC 
Issue 81366 has been already applied to  the MWS.
Please proceed with patch applying process.
Comment 5 ooo 2008-08-21 12:58:39 UTC 
Targeting to OOo3.1

Remarks: the patch uses the transliterate() method that gets a language passed,
which may interfere with the loadModuleByImplName() because it may load a
different module. I'll change that to use the transliterate() method that does
not get a language passed. See also comments in unotools/transliterationwrapper.hxx
Comment 6 ooo 2009-01-13 23:53:12 UTC 
In cws chart35:

revision 266262
sc/source/core/tool/interpr1.cxx

Applied patch adapted to DEV300_m38 source and changed to use transliterate()
method as mentioned above. Verified that the test case document
http://www.openoffice.org/nonav/issues/showattachment.cgi/45744/jis_asc_testcase_ver2.xls
of issue 70213 still calculates correctly.
Comment 7 ooo 2009-01-20 12:45:45 UTC 
Reassigning to QA to verify that nothing changed ;-)
Comment 8 oc 2009-02-10 12:29:21 UTC 
verified in internal build cws_chart35
Comment 9 thorsten.ziehm 2010-02-22 14:49:00 UTC 
This issue is closed automatically. It should be fixed in a version with is
available for longer than half a year (OOo 3.1). If you think this issue isn't
fixed in the current version (OOo 3.2) please reopen it. But then please pay
attention about the field 'target milestone'.
The closure was approved by the Release Status Meeting at 22nd of February 2010
and it is based on the issue handling guideline for fixed/verified issues  :
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues