Apache OpenOffice (AOO) Bugzilla – Issue 83692
Add interface for OnLoadFinished event
Last modified: 2009-10-09 08:11:36 UTC
Currently the OnLoadFinished event is only available via the API, it should be available from the tools > customize > events UI also.
changing target & component
We must provide new UI strings for some of the events that currently aren't visible in the event configuration dialog.
what about creating an alias for OnLoadFinished as this name is not good because occuring before OnLoad just a new name that redirects internally to OnLoadFinished : BeforeOnLoad Then, just advertize this new name BeforeOnLoad (as OnLoadFinished is even not in devGuide)
too late for new strings -> 3.1
Taking over
It has been a while since this issue has been reported. ;-) Anyway, I want to get if fixed. I think the problem isn't the name of the new event, the problem is "OnLoad" that better should be "OnOpen". So if we are talking about an "alias" (I think we have to keep the old one for compatibility), we should introduce "OnOpen" as a replacement for "OnLoad" and keep "OnLoadFinished". This reflects pretty well that "OnOpen" if sent only for documents being "opened" (means: shown to the user), not just "loadede" (means: brought into memory). I will start discussion about this on dev@api.openoffice.org.
After discussing it on dev@api I think that replacing "OnLoad" by "OnOpen" (but keeping the old name for compatibility reasons in deprecated state) is the best way to go.
Yes - I did follow the discussion (every time I had something to add there someone beat me to it..) and it seems this is the right decision.
I added a bunch of other events that also existed internally already. Don't get irritated about how full the listbox now is. :-) Here are the "new" events: "OnCreate" "OnLoadFinished" "OnSaveFailed" "OnSaveAsFailed" "OnCopyTo" "OnCopyToDone" "OnCopyToFailed" "OnViewCreated" "OnPrepareViewClosing" "OnViewClosed" and for Writer "OnMailMergeEnd" "OnFieldMerge" "OnFieldMergeFinished" There are some more events where I'm in doubt whether it makes sense to give access to them for bound macros (they are supported by the EventBroadcaster though): "OnVisAreaChanged" "OnModeChanged" "OnStorageChanged" and for Writer "OnLayoutFinished"
I forgot one: "OnTitleChanged"
I postpone the interface name change to a further CWS and just added the "new" events
@jsk: please verify
Quite a number of autotests might possibly be affected here - anything touching the tools/customize diealog - anything touching eventbindings Adding a few tests to the list of required autotests.
I attached a test document to test the possible assignments. The event "LoadFinished" as well as some others (explained in the test document) can only be bound to global macros, not to document macros.
Created attachment 64667 [details] test case
Created attachment 64668 [details] test case
svn commit -m "#i83692# - Mandatory automated test case plus test document" Sende framework/optional/f_basic_documents.bas Hinzufügen framework/optional/includes/basic_events.inc Hinzuf. (bin) framework/optional/input/BasicDocs/BasicEvents.odt Sende global/system/includes/declare.inc Sende global/system/includes/gvariabl.inc Sende global/tools/includes/required/t_files.inc Sende global/tools/includes/required/t_tools1.inc Übertrage Daten ....... Revision 276066 übertragen.
Close