Apache OpenOffice (AOO) Bugzilla – Issue 84332
Digital signature for macros removed if document is changed
Last modified: 2017-05-20 10:01:59 UTC
If macros in a document are digitally signed and the document is subsequently edited and saved, the digital signature gets removed. This is in contravention of the specs.
Mikhail, is this something for you or should we pass this on to Andreas Bregas? In case it's one for you: what about the target - 2.4 or 3.0? This bug makes macro signature pretty painful to use, but OTOH I don't want to rush a fix as this is a security related area.
It looks like I should start the investigation. If I am not wrong I have already fixed such a problem at the beginning of the macro-signature history. So the functionality seems to be broken now. I would set 2.4 for the beginning.
Code freeze is coming in a week. Please see if it is still possible to fix the problem for 2.4. Thanks.
The problem is that in case there is no dialog in the document, the modified state of the dialog library is true, although no new dialog was inserted. It looks like the insertion of the default "Standard" library could affect the behavior. I leave the bug without target till Monday, but the chances are quite small that the fix will get it in OOo2.4.
Reportedly version 2.1 did not behave this way - it retained macro signature even if document has changed.
Confirm, in 2.1 - no problem.
I forgot about this one. @jsk: according to the "latest" ;-) comments, this issue might be fixed already. Can you please test with a current version?
hi has already tested a similar scenario for OOo3.2, so I add him in CC.
I could confirm that the issue seems resolved for version 3.2.1 . But signatures of the macros get removed if set on a templete. When you open a template with a signed macro and save it as a document, the signatures of the macros get removed. Tested for BASIC macros and version 3.2.1 under Ubuntu. Do I need to open a new issue? Thanks in advance.
Mikhail, please have a look at the latest information. @v1ce: thank you very much for the confirmation and the new findings!
The scenario does not work as expected at least in DEV300_m96 on Solaris. So the bug is still or again there. The problem with template is covered with issue i76318.
Sorry, the last comment from me is not quite correct. The macro-signature was removed there, but only because I have taken ODF1.1 document and have stored it in ODF1.2, that is actually an expected behavior. If I take ODF1.2 document with signed macro, change it and save in ODF1.2 format the macro-signature is not removed. @hi: Could you please verify the issue.
@MAV: Verified with dev300m106: The macro signature remains after document is changed, even when you save with another file name. But take a look to the comment: - Comment #9 From v1ce 2011-01-17 13:17:54 the behavior with templates