Issue 85014 - dmake generates wrong warnings
Summary: dmake generates wrong warnings
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: PC Windows, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-06 05:23 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch for dmake (1.50 KB, patch)
2008-01-06 06:07 UTC, quetschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2008-01-06 05:23:11 UTC
Dmake 4.11 generates "Found file corresponding to virtual target [...]" warnings
for multiple (::) target definitions on native W32 dmakes. This reproduces the
problem:

- - - makefile.mk - - -
SHELL:=cmd.exe 
SHELLFLAGS:=/S /C

all : exists
	@echo Done

exists ::
	+@echo create > $@
- - - makefile.mk - - -

$ rm exists && ./dmake/dmake.exe -rf ../t_shay_2mw.mk
Done
dmake.exe:  Warning: -- Found file corresponding to virtual target [exists].
Comment 1 quetschke 2008-01-06 06:07:02 UTC
Created attachment 50678 [details]
Patch for dmake
Comment 2 quetschke 2008-01-06 06:15:02 UTC
This problem could only be triggered on dmake 4.11 W32 runargv because it returned
0 when the command did finish, the unixy runargv never returned 0 even if the
command did finish and this made the problem only possible on W32.

This problem did only occur for multi targets because they automatically set the
.SEQUENTIAL attribute for its children.

The previous patch fixes these problems.

@shay: If you want to fix the problem in a special CPAN dmake 4.11 version, then
you only need to apply the second hunk of the patch.
Comment 3 quetschke 2008-01-06 21:21:37 UTC
committed to dmake412
Comment 4 quetschke 2008-02-05 22:07:07 UTC
fixed - even though it was not occurring in dmake412 ;)
Comment 5 hjs 2008-02-25 17:01:22 UTC
warning is gone.

but i noticed another one with the testcase, only occuring on a network volume:
-----
Done
dmake.exe:  Warning: -- Target [all] was made but the time stamp has not been
updated.
-----

any clue?
Comment 6 quetschke 2008-02-26 00:14:09 UTC
> any clue?
That new warning should only be there if there is a file name 'all' on your
network volume. If not this is a bug - please open a new issue and keep this
verified ;)
Comment 7 hjs 2009-02-24 11:52:39 UTC
.