Apache OpenOffice (AOO) Bugzilla – Issue 85136
dmake can't find config files when in directory containing $ in name
Last modified: 2013-08-07 15:34:52 UTC
dmake.exe can't find its configuration files when it is run from within a directory that contains a $ character in its name. E.g. put the following in C:\Temp\makefile.mk: all : +@echo Hello and put dmake.exe and its startup\ directory in C:\Temp\$test Then 'cd' to C:\Temp and run: $test\dmake.exe The output is: dmake.exe: Error: -- Configuration file `C:\Temp\est\startup\startup.mk' not found
Usually I would say don't do that ;) I mean using $ in targets/prerequisites is asking for trouble as macros in target names are evaluated before defining the rules or - even worse - dynamic prerequisites are evaluated at run time. I might be able to fix this particular problem by not expanding $(ABSMAKECMD). Your problem comes from startup.mk being searched for in "$(ABSMAKECMD:d)startup/startup.mk" but there might lurk problems in every dynamic macro. It might just work because absolute paths are rarely used.
Created attachment 51412 [details] Patch for dmake
The previous patch fixes the ABSMAKECMD problem and thus the config.mk problem.
Committed. Please verify.
I checked out cws_src680_dmake412, confirmed that the source contains your patch, and re-tested the bug exactly as I originally reported, and I'm afraid that I still get exactly the same error. Should this bug be re-opened, or rejected as "don't do that!"?
Created attachment 51420 [details] Patch for dmake
Created attachment 51422 [details] Patch for dmake
Hmm, I only checked if $(ABSMAKECMD) and $(MAKESTARTUP) were set to the right value and kept the $, but dmake was doing a little more behind our backs. The previous two patches (committed) take care of this and I verified that I now actually can run the following makefile with dmake being installed to a path that has a $ in it. -- makefile.mk -- SHELL:=cmd.exe SHELLFLAGS:=/S /C all : @echo AXXA @echo ABSMAKECMD:$(ABSMAKECMD)A @echo MAKESTARTUP:$(MAKESTARTUP):A -- makefile.mk -- $ ./dmake/dmake.exe AXXA ABSMAKECMD:d:\w1\cws_src680_dmake412\mingw$\dmake\dmake.exeA MAKESTARTUP:d:\w1\cws_src680_dmake412\mingw$\dmake\startup\startup.mk:A Please check again.
Yes, looks good to me now. I can even build perl using a dmake.exe in C:\Temp\$test. Thanks!
ok, last comment from shay counts as "verified" regarding this particular issue. also, i couldn't find regressions regarding nested macros or similar (yes, i tried ;)). but i still don't feel comfortable with this change...
> also, i couldn't find regressions regarding nested macros or similar (yes, i > tried ;)). but i still don't feel comfortable with this change... At first I wasn't feeling comfortable with this either, but I tripple checked that it actually was a bug before. Before the patch a macro holding a (make-)filename was always expanded twice, now it's done only when needed. And removing unneeded Expand() calls is a small run-time optimization ;)
.