Issue 85624 - WW8: exporting and opening again, turns header/footer on
Summary: WW8: exporting and opening again, turns header/footer on
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: save-export (show other issues)
Version: OOH680m4
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: ms_interoperability, oooqa, regression
Depends on:
Blocks: 84957
  Show dependency tree
 
Reported: 2008-01-27 20:21 UTC by cno
Modified: 2013-08-07 14:42 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch sent by fridrich_strba (3.06 KB, text/plain)
2008-02-04 13:07 UTC, openoffice
no flags Details
document with overview and test scenarios (22.32 KB, application/vnd.oasis.opendocument.text)
2008-02-12 00:12 UTC, cno
no flags Details
Test document: odt-file 11A (9.43 KB, application/vnd.oasis.opendocument.text)
2008-02-12 00:13 UTC, cno
no flags Details
same file converted to .doc: 11B (94.50 KB, application/msword)
2008-02-12 00:14 UTC, cno
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description cno 2008-01-27 20:21:59 UTC
Saving As MsWord.doc and opening again, turns header/footer on ...

1 - Create Text document in OOh680_m4
2 - Save as doc (97/200/xp)
3 - Close and reopen in Writer
-> Headers and footers are added... This does not happen in 2.3.1

4 - add manual break with different page style (for example First page)
5 - close and open
-> Headers and footers are also added to new applied page style

= = = different tests
Text document > Save as .doc > In MsWord headers/footers are not shown
Create .doc in MsWord > Open in 2.3.1 and 2.4-dev > headers/footers are not shown
Comment 1 cno 2008-01-27 20:22:49 UTC
set keywords
Comment 2 cno 2008-01-27 22:02:12 UTC
I'm not sure about consequences of this one.
Of course it does show up nasty.
However, the main text area is unchanged, so, as long as nothing is added in the
header/footer, nothing is shown when you open the file in MsW.
Comment 3 michael.ruess 2008-01-28 10:40:09 UTC
MRU->HBRINKM: it looks that the patch from issue 84747 introduced this problem
into OOH680m4 (m3 was ok). 
Just create an empty Writer document, save as WW8 doc, reopen -> document now
has Header/Footer.
Comment 4 openoffice 2008-02-04 13:07:00 UTC
Created attachment 51356 [details]
patch sent by fridrich_strba
Comment 5 openoffice 2008-02-04 13:08:17 UTC
Fridrich sent a patch that solves the problem
Comment 6 fridrich.strba 2008-02-04 13:13:44 UTC
.
Comment 7 openoffice 2008-02-05 08:20:13 UTC
retarget
Comment 8 fridrich.strba 2008-02-05 08:33:54 UTC
Hbrinkm: I cannot agree. I included with this one a serious regression where the
headers and footers are not written correctly (for empty headers only one CR)
that can work a bit with MS Word, but it will leave the documents in a incorrect
state where you cannot edit in Word the headers/footers of those sections. The
impact can be quite bad. I strongly suggest that we still push this one into 2.4
Comment 9 openoffice 2008-02-05 08:43:57 UTC
ready for QA
Comment 10 michael.ruess 2008-02-06 15:50:11 UTC
Reopening issue. Fix/Patch from issue 84747 will not work correctly anymore -
exporting the odt attached there will show Headers/Footers from page 2 on.
Comment 11 michael.ruess 2008-02-06 15:53:02 UTC
MRU->HBRINKM / FRIDRICH_STRBA: as described above, the Patch from issue 84747
won't work correctly anymore with this Patch here.
Comment 12 fridrich.strba 2008-02-06 15:58:07 UTC
@mru: what will be the content of the headers/footers? If they are empty, it is
ok, because the MS Word file-format cannot do anything else: Once there is a
section with header/footer before the one without it, you have to override it by
an empty header footer. Unless you do that, the header and footer from the
previous section will be inherited from the previous section.
Comment 13 michael.ruess 2008-02-06 16:12:19 UTC
The argumentation is not fully true.
- a new empty page is exported/re-imported without ANY header/footer
- OO 1.1 is exported/re-imported document from issue 84747 without ANY
header/footer from page two on
- the Word95 filter exported/re-imported document from issue 84747 without ANY
header/footer from page two on

If one exports/re-imports pages without headers, he is expected to keep this
view. It is possible as the above samples show, so we should implement it
correctly and consistent in my eyes.
Comment 14 fridrich.strba 2008-02-06 16:15:14 UTC
@mru: I just rebuilt with that patch and verified that in the document that has
first page without header/footer and the other with them, the first page is not
having any header/footer. In the document where first page has header/footer and
the others don't have, we export it as a document with header/footer on first
page and with empty header/footer on other pages. This is the only way one can
do it in WW8 file-format. Now, the regression is even more serious and that is
why I insist. Because instead of two CR I write currently only one CR that
renders the documents invalid from the point of view of WW8 file-format. Word
can render them, but you cannot do anything with the headers in the header-less
sections anymore and it is even likely that other applications that rely on
valid WW8 documents might crash with the current state. So, please, a little
effort to integrate this one.
Comment 15 fridrich.strba 2008-02-06 16:18:37 UTC
@mru: this is then a problem of the import. We should then check whether the
headers/footers are empty and not import them. But this bug was about export. I
am not able to create a document using Word 2003 that would have first page with
a header and second without any. There will be an empty header. Never mind, if
you people don't want this fix, just revert the fix from issue 84747 so that we
don't produce invalid documents.
Comment 16 fridrich.strba 2008-02-06 16:19:09 UTC
.
Comment 17 fridrich.strba 2008-02-06 16:40:36 UTC
@mru: accidentally, if you export the document using our Word95 filter and
import into Word 2003, you will have the headers/footers on all pages. So, our
Word95 import/export is getting the documents wrong. I might have a look at that
for 3.0, but now the fix is simply crucial not to screw badly the WW8
import/export for 2.4
And it is true that my fix for this achieved among other things that the
header/footer-less documents will not have header/footer, not even empty. That
is possible in the file-format.
But as I said, if you don't want the fix, please revert the patch in issue
84747. I really am not going to spend more time to fix. I got the information
about this bug report last friday, I spent the night from Friday to Saturday
generating documents and studying the file-format to do the right thing. I have
this patch in ooo-build, so... I really don't want to spend my energy fighting
wind-mills :(
Comment 18 fridrich.strba 2008-02-06 16:42:48 UTC
Yes, I created a regression, I admit. I spent a night of my own private time to
fix the regression. Now, what else can I do?
Comment 19 cno 2008-02-06 17:02:15 UTC
@Fridrich, all,
I read this all while I bite my lips..
A longer standing wish from me, and planned for next week, is to dive in all
scenarios for headers / footers / margins in relation to ww import/export,
following on issues like 60332 etc. Had quite some correspondence about this
with fme and cmc. 
So that might influence this issue, I feel quit uncomfortable. So I'll see what
I can do tomorrow.
Comment 20 cno 2008-02-07 18:17:49 UTC
Hi,
I've time planned to analyse/test various issues/scenarios 
(11522, 34591, 44520, 60332, 66619, 72211, 73533, 73652, ...)
If patches from 84747 and this issue solve (part of) those problems, withou
causing new of course, that would be great. I'll be happy to test and report.
So I would like if this can be integrated or if someone has a link to a build
for me. Thanks.
Comment 21 fridrich.strba 2008-02-08 11:27:57 UTC
@cornouws: Cor, if you want to try, a build with this fix and many other
ooo-build changes is to find here:
http://hei.unige.ch/~strba5/novell/OOo_2.4.0_080208_LinuxIntel_install.tar.gz
Cheers
Comment 22 cno 2008-02-08 12:03:55 UTC
Thanks Fridrich!
Comment 23 michael.ruess 2008-02-08 14:17:49 UTC
Verified in CWS sw24bf04.
Comment 24 cno 2008-02-12 00:11:33 UTC
Sorry to say that there is something wrong when:
 - 1st page and next pages have different styles, 
 - in combination with soft page breaks. 
After conversion to .doc, reopening in OOo or opening in Word, you see that the
following pages get the style of the 1st page.

Tested in OOo_2.4.0_080208_LinuxIntel_install.tar.gz (build 2.3.99.2)

 -> reopen

I'll attach two of my testdocuments + a document holding an overview and test
scenarios.

My proposal would be:
1 - do some further testing (not all 288 basic scenarios in the attachment are a
must) both in 2.3.1 and 2.4-devxxx. (OTOH, some details in the test have to be
improved).
2 - analyse (from issues and testing) where problems lie.
3 - then see and clearly describe what features of OOo match with those in Word
(nice to have on hand while developing)
4 - see if the problems should be fixable. And possibly, if choices have to be
made, where priorities can be.
Quite some work with target 3.0 (see issue 60332).
But definitely important. See list of issues in attachment.
Comment 25 cno 2008-02-12 00:12:40 UTC
Created attachment 51462 [details]
document with overview and test scenarios
Comment 26 cno 2008-02-12 00:13:23 UTC
Created attachment 51463 [details]
Test document: odt-file 11A
Comment 27 cno 2008-02-12 00:14:19 UTC
Created attachment 51464 [details]
same file converted to .doc: 11B
Comment 28 andreschnabel 2008-02-12 06:31:32 UTC
hi cor, *

please don't mix up new research implementation with fixing a stopper (regression).
This issue has clearly been flagged as showstopper with target 2.4 - please move
all but the initial named regression to an other issue. Actually I don't know,
if we still have a regression in 2.4 or not.
Comment 29 cno 2008-02-12 07:28:26 UTC
sorry indeed. I lost track in issues.
Should be issue 84747 that is reopened, since the fix is not ok.
  -> set this one back to fixed
Comment 30 fridrich.strba 2008-02-12 07:51:44 UTC
.
Comment 31 michael.ruess 2008-02-12 07:58:44 UTC
Resetting to "verified".

Cor,
could you please test your sample again with OOH680m7; there, this issue's fix
will be integrated. If needed, please file a new issue then. Thanks for your
patience!
Comment 32 cno 2008-02-12 08:08:36 UTC
I'll do so.
Comment 33 michael.ruess 2008-02-12 09:41:40 UTC
Checked fix in OOH 680m7.