Issue 85730 - SalFrame::SetIcon must not use icons stored in the executable
Summary: SalFrame::SetIcon must not use icons stored in the executable
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: 680m242
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: Stephan Bergmann
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-30 14:57 UTC by Stephan Bergmann
Modified: 2008-02-11 09:36 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Stephan Bergmann 2008-01-30 14:57:40 UTC 
Reportedly, the various platform-specific implementations of SalFrame::SetIcon
use icons extracted from the executable binary file.  On CWS sb83, the
executable binary (soffice.bin) is no longer brand specific, so this mechanism
of obtaining brand specific icons now fails.

Instead, icons should probably be constructed from bitmaps obtained from the
resource manager.  One possible resource file to store those bitmaps in is
ooo...res (generic OOo) resp. iso...res (brand specific override of ooo...res).
 For Windows, hro should know how to create HICONs from bitmaps.

From my point of view, this issue can either be fixed directly on CWS sb83, or
on another CWS targeting OOo 3.0 (as the defect it fixes is rather trivial).
Comment 1 philipp.lohmann 2008-02-08 15:41:05 UTC 
Meanwhile we want the windows icons in the executable after all.
Comment 2 Stephan Bergmann 2008-02-11 09:35:13 UTC 
.
Comment 3 Stephan Bergmann 2008-02-11 09:36:26 UTC 
.