Issue 85870 - [Notes2] Spellchecking: Manual spellchecking does not work in notes
Summary: [Notes2] Spellchecking: Manual spellchecking does not work in notes
Status: CONFIRMED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 680m243
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-04 22:09 UTC by christoph
Modified: 2017-05-20 11:15 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description christoph 2008-02-04 22:09:43 UTC
MANUAL SPELLCHECKING DOES NOT WORK IN NOTES
The following problem has been found in the build “edgy-jdk-2474-notes2â€.

Manual spellchecking does not work in Note Windows. When called, the Writer just
checks the document text or does nothing (is dependent on the kind of activation).

Steps to reproduce:
1.Open a document and enter some words with spelling error
2.Create a new note and enter some words with spelling error
3.Place the text cursor in front of some of the words created in step 2.
4.Activate (manual) spellchecking by Tools – Spellcheck...

Expected behavior: The spellchecking starts with the wrong words in the Note
Window created in step 2.
Current behavior: The spellchecking starts in the document. The Note Window is
not considered at all.

Proposal: Notes Windows are a kind of special region and therefore should be
part of the “special region†in “Tools – Options – Language Settings – Writing
Aids: Check special regionsâ€.
Unfortunately, there seem to exist other issues with that functionality which
prevent a sane integration. Please refer to the specification in the Notes2 wiki
or contact me directly. Thanks!
Comment 1 christoph 2008-02-04 22:10:07 UTC
CALLING THE MANUAL SPELLCHECKING FROM THE SPELLCHECKING CONTEXT MENU
The following problem has been found in the build “edgy-jdk-2474-notes2â€.

There seems to be a related problem with the spellchecking dialog: Unknown words
are underlined and can be right-clicked to open the usual spellchecking dialog.
This dialog offers “Spellchecking...†which does nothing at the moment.
Normally, the manual spellchecking will be run.
Comment 2 christoph 2008-02-04 22:10:21 UTC
WRONG STATE OF SPELLCHECKING TOOLBAR SYMBOL IF FOCUS IN NOTE WINDOW
The following problem has been found in the build “edgy-jdk-2474-notes2â€.

The toolbar symbol which toggles the automatic spellchecking does not work as
expected when a Note Windows has the focus (focus: cursor is located in a Note
Window).

Steps to reproduce:
1.Create a document and enable automatic spellchecking (button of automatic
spellchecking is pressed)
2.Create a Note and enter some text (maybe with spelling mistakes)
3.Change the focus from the Note Window to the document text and back to the
Note Window

Expected behavior: The button for automatic spellchecking keeps activated,
because the spellchecking marks can be seen in both the document and the Note
Windows.

Current behavior: The button for automatic spellchecking changes it's state
(document text = on; Note Window = off).

In contrast, the option in “Tools – Options – Language Settings – Writing Aids:
Check spelling as you type†works as expected.

~~~

Furthermore, the state of the spellchecking toolbar symbol can not be changed
when clicking on it.

Steps to reproduce (use the document created in the steps above)
4.Set the cursor in the Note Window, the Note Window has now the focus.
5.Click on the symbol automatic spellchecking

Expected behavior: Spellchecking can be turned off/on.

Current behavior: The button for automatic spellchecking can not be activated
(pressed) and spellchecking will remain activated.
Comment 3 christoph 2008-02-04 22:10:42 UTC
SETTING THE LANGUAGE DOES NOT WORK AT ALL (SELECTED TEXT / PARAGRAPH / ALL TEXT)
The following problem has been found in the build “edgy-jdk-2474-notes2â€.

Writer provides several ways to change the language of a portion of text or the
complete document:
the menu “Tools – Options – Language Settings – Languages: Default languages for
documentsâ€
the application menu “Tools – Language – For Selection OR For Paragraph OR For
all Textâ€
the status bar by using the context menu.
No one of these options do work in the Notes.

Steps to reproduce (languages are just examples):
1.Create a document and enter some German words (make sure that the document
language is still English)
2.Create a Note and enter some German words
3.Change the document language by: “Tools - Language – For all Text: German
(Germany)â€

Expected result: The automatic spellcheck marks do disappear because the correct
language is now set properly.

Current result: Nothing happens and the spellchecking marks will remain in BOTH
Notes Windows and document text.

4.Move the focus to the document text
5.Change the document language by: “Tools - Language – For all Text: German
(Germany)â€

Expected result: The automatic spellcheck marks do disappear because the correct
language is now set properly for all elements.

Current result: The automatic spellcheck marks dissappear in the document text,
BUT nothing happens in the Notes Windows. There, the language is not changed.

PLEASE NOTE: It has NOT yet decided by the iTeam how to handle language settings
which refer to the whole document.
The following behavior are just rough ideas:
1.If the user wants to change the language setting for the whole document, then
the Notes should respect this setting like the document text does (change of
language setting: e.g. “Default languages for documents†or “For all Textâ€).
[Open Questions: Does this interfere with the specification to adapt the
formatting of time and date of the Note Property Data according to the system
language? Can we make sure that the user really wants to use the same language
in the text?]
2.If the user changes the setting for the document or the whole text, then only
the setting for the normal document text changes. The language setting for the
Note Windows is inherited from the OpenOffice.org language setting. In general,
the user will be able to change the language in the Notes Windows; but only for
one Note Window, paragraphs or selections.

Please contact the iTeam which behavior should be implemented.
Comment 4 max.odendahl 2008-02-04 22:27:09 UTC
confirm, target
Comment 5 christoph 2008-04-13 13:13:43 UTC
Issues in this collection have been separated according to the request by mod
(2008-04-12):

* this issue covers: Manual spellchecking does not work in notes
* issue #88220 : CALLING THE MANUAL SPELLCHECKING FROM THE SPELLCHECKING CONTEXT
MENU
* issue #88221 : WRONG STATE OF SPELLCHECKING TOOLBAR SYMBOL IF FOCUS IN NOTE WINDOW
* issue #88222 : SETTING THE LANGUAGE DOES NOT WORK AT ALL (SELECTED TEXT /
PARAGRAPH / ALL TEXT)
Comment 6 thomas.lange 2008-07-16 12:01:11 UTC
TL->MOD: After debugging into this and asking for the opinions of colleagues we
agreed the the most likely reason for this is the origin setting of the MapMode
of your window.
For example if I have a draw text object in writer that object does usually not
have a 0/0 origin for the MapMode (which is member of OutputDevice the base
class for all windows). And that origin also changes when scrolling the document
window horizontally or vertically. Whereas the MapMode's origin of your window
remains 0/0 all the time.
However that in itself needs not to be wrong for example I was told Calc cells
are always forced to have a 0/0 origin in the MapMode.

If it is wrong or not depends on your mapMode handling in your window
implementation. But if one makes the doucument window smaller (horizontally) and
scrolls a bit more right or left the horizontal offeset from the context menu
seems to be in some relation to the size visual part of the page. And that as
well should effect the MapMode of your notes window.
Thus we concluded that the MapMode's origin handling in your window is the most
likely reason for this offset problem.

I also was told that it might be worthwhile to debug the BeginTextEdit and
EndTextEdit functions in svx since those are the ones that should be used with
your implementation and the MapMode might be modfied there as well.

With the time currently at hand this is all I can say about this. :-(
I hope it will be helpful to you...
Comment 7 max.odendahl 2008-07-17 09:43:34 UTC
mod->tl:

thanks for your investigation, with that info in mind, I'll try to look deeper
into it.

>>And that origin also changes when scrolling the document
>>window horizontally or vertically

Could you let me know where in the code this is done and I can have a look at in
the debugger where this is coming from?
Comment 8 max.odendahl 2008-11-12 15:02:23 UTC
new target, no time for this currently
Comment 9 Marcus 2017-05-20 11:15:21 UTC
Reset assigne to the default "issues@openoffice.apache.org".