Apache OpenOffice (AOO) Bugzilla – Issue 8607
OOO_STABLE_1_PORTS/X11: psprint printing fixes from X11 Beta
Last modified: 2004-03-25 07:42:38 UTC
This patch contains the code that implemented MacOS X printing on our October X11 Public Beta release. I don't consider it good enough quality to commit as it changes a lot of the layout of the code and has large chunks of Mac OS X only code. Instead, I'd like comments on the patch from non-MacOS X people (Ed has already seen this). I'll incorporate those comments and respin the patch for actual approval. Thanks, Dan
Created attachment 3289 [details] patch for psprint module. cd SRC_ROOT/psprint, patch -p0 < /path/to/patch
Note that this patch doesn't delete the temporary pdf file created during the printing process, but that will be something that happens before I submit for final approval. Dan
The patch looks good to me as it does not change the code flow for any platform besides Mac as far as i can see; i'd like to note some points, though: - there are lots of indentation changes where now seem to be tabs; the last i remember was that for new code there should be 4 spaces per indent (because this is viewable everywhere without problems). - i think the large #ifdef MACOSX block in printerjob.cxx in PrinterJob::EndJob merits its own function which could be called in a short #ifdef MACOSX block in EndJob
Will clean up and resubmit for approval per suggestions.
Starting for fixup...
Created attachment 4064 [details] cd to $SRC_ROOT/psprint; patch -p0 < /path/to/patch/file This patch should NOT be committed, only for review.
Hi, the 121602 patch is a cleanup of the 100902 patch. Can someone please look at the patch and give comments? I'm still not going to submit this for approval as I need to make sure the # copies code works (there may be further changes in that department). Please review and comment, especially on cross-platform correctness. Thanks, Dan
I must also verify that this code works on 10.1 as I've made fairly substantial changes to the code flow. Dan
still looks good. Especially the ProcessAndPrint function makes the code a lot more readable IMHO.
Created attachment 4279 [details] cd to SRC_ROOT/psprint, patch -p0 < /path/to/patchfile Implements printing code from Final Beta, including previous cleanups here
Hi, Can someone approve "psprint.FINALBETAv1.010303.patch" for commit to OOO_STABLE_1_PORTS? This patch supercedes previous ones and contains up-to-date printing code for OS X. Thanks, Dan
As far as i can see the patch moves top level psprint to STABLE_1_PORTS. That should not be a problem though and fix some issues on the fly. Approved.
Patch only moves these components to current (SRX644): source/fontsubset/* source/fontmanager/* inc/psprint/inc/fontmanager.hxx inc/psprint/inc/fontcache.hxx
Created attachment 4394 [details] cd $SRC_ROOT/psprint, patch -p0 < /path/to/patchfile same as 010303 patch but without SRX644 updates
Committed the 012103 patch to OOO_STABLE_1_PORTS. This patch removes the updates to SRX644 for the fontsubset/fontmanager code, and contains only the printing fixes. Dan
Also moved these directories/sources up to SRX644: source/fontsubset/* source/fontmanager/* inc/psprint/inc/fontmanager.hxx inc/psprint/inc/fontcache.hxx Dan
Fixed in 103 GM.
close issue.