Apache OpenOffice (AOO) Bugzilla – Issue 86795
mingw: catch-up fix for basegfx build breakage
Last modified: 2009-12-27 12:03:09 UTC
.
Created attachment 51967 [details] tono's patch
fixed in the CWS mingwport12
@vg: I was too busy last week to raise the issue for the patch. Thank you very much for taking care of it.
Created attachment 52077 [details] breaker in berkeleydb
Created attachment 52078 [details] breaker in libxslt
There are 2 additional problems since DEV300 m2. Please see attachments
@vg: The breaks in berkeleydb and libxslt are caused by the removal of expporting of the dmake macro PWD from solenv/inc/startup/wnt/macros.mk. I will attatch patches to add it in makefiles of berkeleydb and libxslt and remedies the breaks.
Created attachment 52111 [details] Patch for berkeleydb
Created attachment 52112 [details] Patch for libxslt
Wait, wait, why is PWD exported there? The need to export it was stemming from a dmake bug (fixed in 4.8 or so.). If you just without comment re-introduce it, it might just go away again, when ause or I find it and thing this is not needed anymore. So where is the bug?
@vq: As a side effect, the exporing of PWD had been helping the mentioned two external module build to use mixed path instead of cygwin path for the working directory. Without this, we have to modify the patch for configure scripts and makefiles conditionally for mingw. I think just exporting PWD in mingw conditional part of the module makefiles in the two modules is simpler.
I am not opposed to exporting PWD, but we need a comment there pointing to this explanation. Yes, that is a lucky coincidence that the PWD macro gets converted to the mixed mode form and exporting it forces the following shell to use this form. Sounds a little fragile to me, but if it works for you .. You should put it between .IF "$(GUI)$(COM)"=="WNTGCC" .. .ENDIF as this is clearly platform dependent.
set target
Closing the issue as the cws has already been integrated.