Issue 86974 - more pythonic officehelper.py
Summary: more pythonic officehelper.py
Status: CONFIRMED
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: OOo 2.2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-12 20:17 UTC by htgoebel
Modified: 2013-07-30 02:39 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
more pythonic officehelper.py (3.26 KB, text/plain)
2008-03-12 20:18 UTC, htgoebel 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description htgoebel 2008-03-12 20:17:08 UTC 
Current implementation (as of 2.2) of the officehelper.py module is quite
un-pythonic. Enclosed please find a enhanced version.

Major changes are:
- removed all-surrounding try-except. If this code section fails for another
reason than "NoConnectException" the normal Python exception mechanism is used.
- simplified string-join
- simplified loop (as requested in the code :-)
- more pythonic coding style
Comment 1 htgoebel 2008-03-12 20:18:03 UTC 
Created attachment 52061 [details]
more pythonic officehelper.py
Comment 2 Martin Hollmichel 2008-03-26 10:48:37 UTC 
reassign.
Comment 3 joergbudi 2008-04-16 21:13:14 UTC 
Hi,

the problem of your (certainly nicer) code is, that it is an incompatible change
(meaning that other exceptions than BootstrapException can now leave the
function which may break existing code .... ). All functions once made public
API can only be changed compatible.

So probably the right thing is to take your code as bootstrap2() and deprecate
bootstrap(). Ok for you ? (However, I don't know atm when I will setup a next
pyuno CWS).

Bye,

Joerg
Comment 4 Rob Weir 2013-03-11 15:00:59 UTC 
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob
Comment 5 Rob Weir 2013-07-30 02:39:44 UTC 
Reset assignee on issues not touched by assignee in more than 1000 days.